Skip to content

Add ILike filter, fix Like filter#173

Merged
arogachev merged 7 commits intomasterfrom
172-ilike
Apr 2, 2024
Merged

Add ILike filter, fix Like filter#173
arogachev merged 7 commits intomasterfrom
172-ilike

Conversation

@arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?

@arogachev arogachev requested a review from a team April 1, 2024 08:28
@arogachev arogachev self-assigned this Apr 1, 2024
@what-the-diff
Copy link

what-the-diff bot commented Apr 1, 2024

PR Summary

  • Introduction of ILike.php:
    A new class ILike has been introduced. It functions as a case-insensitive field-value match filter, providing flexibility in data-filtering options.

  • Modification in Like.php:
    The existing Like class has been updated to perform like-match filter operations in a case-sensitive manner, enhancing the accuracy of data filtering.

  • New ILikeHandler.php File:
    A new class ILikeHandler has been added, serving as the handling mechanism for the newly introduced ILike filter, enabling efficient application of the case-insensitive like-match filter.

  • Updates to LikeHandler.php:
    The LikeHandler class has been revised to cater to case-sensitive field value filtering, complementing the specific requirements of the Like filter.

  • Expansion of IterableDataReader.php:
    The IterableDataReader class now supports the ILikeHandler for better handling of the ILike filter, enhancing the data reading capabilites of the system.

  • ILikeTest.php Added for Testing:
    The ILikeHandler class is now backed with dedicated test cases present in the new ILikeTest file, ensuring the reliability of the new feature introduced.

  • Enhancements in LikeTest.php:
    Changes have been made in the test cases under the LikeTest class, providing a more comprehensive testing setup involving actual items to be filtered. This is expected to improve the quality assurance process.

@arogachev arogachev added type:feature New feature type:bug Bug labels Apr 1, 2024
@arogachev arogachev linked an issue Apr 1, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (210dbc1) to head (0c4eb15).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #173   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       236       242    +6     
===========================================
  Files             26        28    +2     
  Lines            597       609   +12     
===========================================
+ Hits             597       609   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev added this to the 1.1 milestone Apr 1, 2024
@arogachev arogachev merged commit fc7edca into master Apr 2, 2024
@arogachev arogachev deleted the 172-ilike branch April 2, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ILike filter

3 participants