You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enhancements to Ordering Functions
We've introduced a new helper class named OrderHelper. This class will take care of tasks related to converting and managing orders. It simplifies the process of working with orders, promotes code reuse, and centralizes this specific functionality.
Refactoring Changes in Sort.php
The existing process that transformed order strings into arrays is now handled by a new method OrderHelper::stringToArray. This should help us manage this function more globally, increasing efficiency.
Similarly, the procedure for converting an order array back into a string now has been replaced with a call to OrderHelper::arrayToString. With this enhancement, code maintenance will be simplified because we are managing this operation from a single place.
Test Coverage Improvements
In order to verify the functionality of our new OrderHelper class, we've added OrderHelperTest.php. This ensures that the methods in 'OrderHelper' class function as expected and will alert us to any future disruptions to its functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.