Merged
Conversation
Member
samdark
commented
Sep 29, 2024
samdark
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
vjik
requested changes
Sep 29, 2024
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
samdark
commented
Oct 17, 2024
samdark
commented
Oct 17, 2024
Member
Author
|
Applied suggestions and fixed some additional stuff. |
vjik
requested changes
Oct 19, 2024
Member
vjik
left a comment
vjik
left a comment
There was a problem hiding this comment.
What about similar fixes in KeysetPaginator?
Member
Author
|
@vjik good suggestions. Applied. |
vjik
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.