Fix null handling in IterableDataReader + Add more tests#234
Merged
Conversation
vjik
changed the title
null handling in IterableDataReader + Add more tests
vjik
added
status:code review
Tigrov
approved these changes
Aug 24, 2025
rossaddison
added a commit
to rossaddison/data-cycle
that referenced
this pull request
Aug 25, 2025
Applied yiisoft/data/pull/234 Moved tests folder into psalm.xml - Level 1 tested EntityReader's readOne function's limit(1) has been removed to get the msi to 100. A suitable test needs to be developed to check for the IncrementInteger mutant on the readOne function with the mutant that changes limit(1) to limit(2) still causing a failure with current tests not picking it up mainly due to the \Generator->current returning mixed type where null, array, and object have to be checked in readOne with false also being returned.
rossaddison
added a commit
to rossaddison/data-cycle
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: yiisoft/data-db#101