Add callback to Query::all() and Query::one()#925
Merged
Conversation
Member
Tigrov
commented
Jan 27, 2025
Tigrov
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Fixed issues | yiisoft/data-db#50 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
=========================================
Coverage 99.24% 99.24%
- Complexity 1537 1547 +10
=========================================
Files 98 98
Lines 3824 3840 +16
=========================================
+ Hits 3795 3811 +16
Misses 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
requested changes
Jan 29, 2025
# Conflicts: # UPGRADE.md # src/Query/Query.php # tests/Common/CommonQueryTest.php
Tigrov
added
status:code review
vjik
requested changes
Apr 2, 2025
Member
|
Add line to changelog |
samdark
approved these changes
Apr 2, 2025
vjik
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.