Skip to content

Make container optional#198

Merged
vjik merged 2 commits intomasterfrom
without-container
Dec 2, 2023
Merged

Make container optional#198
vjik merged 2 commits intomasterfrom
without-container

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented Nov 29, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Nov 29, 2023

PR Summary

  • Enhancement for flexibility in the project
    The update allows the use of container components to be optional. This improves flexibility in how you can use or configure the components of our project.

  • Making parameters option in the Factory
    The change in the Factory allows the 'container' variable to be nullable. This means you can choose to not include it when using this portion of the code.

  • Updating methods in FactoryInternalContainer
    Updates to the 'get' and 'has' methods now allow for checks on container presence to use the null-safe operator. This checks if the container variable exists and is not null before using it, avoiding any potential errors.

  • Improved testing for the Factory component
    A new test has been added to check how objects are created and maintained their uniqueness. This helps ensure that our Factory component is doing its job effectively and correctly.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53d1a90) 100.00% compared to head (9ccda20) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #198   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        42        42           
===========================================
  Files              3         3           
  Lines             95        95           
===========================================
  Hits              95        95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team November 29, 2023 07:47
@vjik vjik added the status:code review The pull request needs review. label Nov 29, 2023
@vjik vjik merged commit bbcd13a into master Dec 2, 2023
@vjik vjik deleted the without-container branch December 2, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants