Skip to content

Add StrictFactory#214

Merged
vjik merged 8 commits intomasterfrom
strict
Dec 9, 2024
Merged

Add StrictFactory#214
vjik merged 8 commits intomasterfrom
strict

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented Oct 31, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (32b68fc) to head (db4878d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #214   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        42        48    +6     
===========================================
  Files              3         4    +1     
  Lines             95       108   +13     
===========================================
+ Hits              95       108   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team October 31, 2024 11:57
@vjik vjik added the status:code review The pull request needs review. label Oct 31, 2024
@samdark
Copy link
Copy Markdown
Member

samdark commented Oct 31, 2024

It's good implementation-wise. What's the use case?

@vjik
Copy link
Copy Markdown
Member Author

vjik commented Nov 1, 2024

It's good implementation-wise. What's the use case?

I want to try to use it in Yii Queue refactoring: yiisoft/queue#222

Co-authored-by: Aleksei Gagarin <roxblnfk@ya.ru>
@vjik vjik merged commit 1b69b8a into master Dec 9, 2024
@vjik vjik deleted the strict branch December 9, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants