Skip to content

Add support for yiisoft/html version ^4.0#89

Merged
vjik merged 3 commits intomasterfrom
html4
Mar 21, 2026
Merged

Add support for yiisoft/html version ^4.0#89
vjik merged 3 commits intomasterfrom
html4

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented Mar 20, 2026

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 20, 2026
View reviewed changes
Comment thread .github/workflows/build.yml Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bb65bac) to head (1904f03).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##              master       #89   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       240       240           
===========================================
  Files             17        17           
  Lines            608       608           
===========================================
  Hits             608       608

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov
Copy link
Copy Markdown
Member

Tigrov commented Mar 20, 2026

Only the tests failed.

@vjik vjik requested review from a team and Tigrov March 20, 2026 08:05
@vjik vjik added the status:code review The pull request needs review. label Mar 20, 2026
Tigrov
Tigrov approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Tigrov Tigrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without lower version test?

@vjik
Copy link
Copy Markdown
Member Author

vjik commented Mar 20, 2026

Without lower version test?

There will problem with HTML. It's different for yiisoft/html 3 and 4.

@vjik vjik merged commit d6acc55 into master Mar 21, 2026
26 checks passed
@vjik vjik deleted the html4 branch March 21, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark approved these changes

@Tigrov Tigrov Tigrov approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vjik @Tigrov @samdark @github-advanced-security