Skip to content

Bump minimal yiisoft/html version to 3.13 and add support of ^4.0#386

Merged
vjik merged 3 commits intomasterfrom
html4
Mar 20, 2026
Merged

Bump minimal yiisoft/html version to 3.13 and add support of ^4.0#386
vjik merged 3 commits intomasterfrom
html4

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented Mar 18, 2026

Q A
Is bugfix?
New feature?
Breaks BC?

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e409d3f) to head (be8e233).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #386   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       806       806           
===========================================
  Files             48        48           
  Lines           2677      2677           
===========================================
  Hits            2677      2677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team March 18, 2026 11:55
@vjik vjik added the status:code review The pull request needs review. label Mar 18, 2026
Comment thread composer.json
@samdark samdark requested a review from Copilot March 18, 2026 19:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the package to be compatible with newer yiisoft/html releases by bumping the minimum supported version to 3.13 and allowing ^4.0, along with aligning internal tag/widget instantiation and updating expected HTML output in tests.

Changes:

  • Bump dependency constraint for yiisoft/html to ^3.13 || ^4.0 and adjust test script invocation.
  • Replace deprecated/changed yiisoft/html factories (e.g., ::tag(), ::create(), CustomTag::name()) with constructors in production code.
  • Update test expectations to match the new attribute rendering order produced by yiisoft/html (and related rendering changes).

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
composer.json Bumps yiisoft/html constraint to `^3.13
CHANGELOG.md Documents the dependency bump/support change.
src/Field/Select.php Switches select tag initialization to constructor-based API.
src/Field/RadioList.php Switches radio list widget initialization to constructor-based API.
src/Field/CheckboxList.php Switches checkbox list widget initialization to constructor-based API.
src/Field/ButtonGroup.php Switches button group widget initialization to constructor-based API.
src/Field/Fieldset.php Switches fieldset tag initialization to constructor-based API.
src/Field/Base/ButtonField.php Uses constructor-based button tag creation for default button instance.
src/Field/Base/BaseField.php Uses constructor-based CustomTag for container open/close rendering.
src/Field/Part/Error.php Uses constructor-based CustomTag for header/error/container rendering.
src/Field/ErrorSummary.php Uses constructor-based CustomTag for header rendering.
src/Field/Checkbox.php Updates docblock reference for attribute rendering method.
tests/ConfigTest.php Updates expected HTML attribute order.
tests/Theme/ThemeTest.php Updates expected HTML attribute order across themed inputs.
tests/PureField/FieldTest.php Updates expected HTML attribute order for pure field rendering.
tests/PureField/FieldFactoryTest.php Updates expected HTML attribute order for factory-created fields.
tests/Field/TextTest.php Updates expected HTML attribute order for text field and container attributes.
tests/Field/TextareaTest.php Updates expected HTML attribute order for textarea field.
tests/Field/EmailTest.php Updates expected HTML attribute order for email field.
tests/Field/UrlTest.php Updates expected HTML attribute order for URL field.
tests/Field/TelephoneTest.php Updates expected HTML attribute order for telephone field.
tests/Field/PasswordTest.php Updates expected HTML attribute order for password field.
tests/Field/NumberTest.php Updates expected HTML attribute order for number field.
tests/Field/HiddenTest.php Updates expected HTML attribute order for hidden field.
tests/Field/FileTest.php Updates expected HTML attribute order for file field and related uncheck inputs.
tests/Field/DateTest.php Updates expected HTML attribute order for date field.
tests/Field/DateTimeLocalTest.php Updates expected HTML attribute order for datetime-local field.
tests/Field/TimeTest.php Updates expected HTML attribute order for time field.
tests/Field/ColorTest.php Updates expected HTML attribute order for color field.
tests/Field/RangeTest.php Updates expected HTML attribute order for range field (incl. output span attrs).
tests/Field/SelectTest.php Updates expected HTML attribute order for select field cases (e.g., multiple, aria attrs).
tests/Field/CheckboxTest.php Updates expected HTML attribute order for checkbox field and label-placement cases.
tests/Field/CheckboxListTest.php Updates expected HTML attribute order for checkbox list rendering.
tests/Field/RadioListTest.php Updates expected HTML attribute order for radio list rendering.
tests/Field/SubmitButtonTest.php Updates expected HTML attribute order for submit button with custom button tag.
tests/Field/Base/InputFieldTest.php Updates expected HTML attribute order for base input field behavior.
tests/Field/Base/DateTimeInputFieldTest.php Updates expected HTML attribute order for base datetime input field.
tests/Field/Base/ButtonFieldTest.php Updates expected HTML attribute order for base button field behavior.
tests/Field/Base/PartsFieldTest.php Updates expected HTML attribute order for container part attributes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vjik vjik merged commit dc9e595 into master Mar 20, 2026
26 checks passed
@vjik vjik deleted the html4 branch March 20, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants