Conversation
Member
vjik
commented
Mar 18, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 806 806
===========================================
Files 48 48
Lines 2677 2677
===========================================
Hits 2677 2677 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tigrov
approved these changes
Mar 18, 2026
Tigrov
reviewed
Mar 18, 2026
samdark
approved these changes
Mar 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the package to be compatible with newer yiisoft/html releases by bumping the minimum supported version to 3.13 and allowing ^4.0, along with aligning internal tag/widget instantiation and updating expected HTML output in tests.
Changes:
- Bump dependency constraint for
yiisoft/htmlto^3.13 || ^4.0and adjust test script invocation. - Replace deprecated/changed
yiisoft/htmlfactories (e.g.,::tag(),::create(),CustomTag::name()) with constructors in production code. - Update test expectations to match the new attribute rendering order produced by
yiisoft/html(and related rendering changes).
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Bumps yiisoft/html constraint to `^3.13 |
| CHANGELOG.md | Documents the dependency bump/support change. |
| src/Field/Select.php | Switches select tag initialization to constructor-based API. |
| src/Field/RadioList.php | Switches radio list widget initialization to constructor-based API. |
| src/Field/CheckboxList.php | Switches checkbox list widget initialization to constructor-based API. |
| src/Field/ButtonGroup.php | Switches button group widget initialization to constructor-based API. |
| src/Field/Fieldset.php | Switches fieldset tag initialization to constructor-based API. |
| src/Field/Base/ButtonField.php | Uses constructor-based button tag creation for default button instance. |
| src/Field/Base/BaseField.php | Uses constructor-based CustomTag for container open/close rendering. |
| src/Field/Part/Error.php | Uses constructor-based CustomTag for header/error/container rendering. |
| src/Field/ErrorSummary.php | Uses constructor-based CustomTag for header rendering. |
| src/Field/Checkbox.php | Updates docblock reference for attribute rendering method. |
| tests/ConfigTest.php | Updates expected HTML attribute order. |
| tests/Theme/ThemeTest.php | Updates expected HTML attribute order across themed inputs. |
| tests/PureField/FieldTest.php | Updates expected HTML attribute order for pure field rendering. |
| tests/PureField/FieldFactoryTest.php | Updates expected HTML attribute order for factory-created fields. |
| tests/Field/TextTest.php | Updates expected HTML attribute order for text field and container attributes. |
| tests/Field/TextareaTest.php | Updates expected HTML attribute order for textarea field. |
| tests/Field/EmailTest.php | Updates expected HTML attribute order for email field. |
| tests/Field/UrlTest.php | Updates expected HTML attribute order for URL field. |
| tests/Field/TelephoneTest.php | Updates expected HTML attribute order for telephone field. |
| tests/Field/PasswordTest.php | Updates expected HTML attribute order for password field. |
| tests/Field/NumberTest.php | Updates expected HTML attribute order for number field. |
| tests/Field/HiddenTest.php | Updates expected HTML attribute order for hidden field. |
| tests/Field/FileTest.php | Updates expected HTML attribute order for file field and related uncheck inputs. |
| tests/Field/DateTest.php | Updates expected HTML attribute order for date field. |
| tests/Field/DateTimeLocalTest.php | Updates expected HTML attribute order for datetime-local field. |
| tests/Field/TimeTest.php | Updates expected HTML attribute order for time field. |
| tests/Field/ColorTest.php | Updates expected HTML attribute order for color field. |
| tests/Field/RangeTest.php | Updates expected HTML attribute order for range field (incl. output span attrs). |
| tests/Field/SelectTest.php | Updates expected HTML attribute order for select field cases (e.g., multiple, aria attrs). |
| tests/Field/CheckboxTest.php | Updates expected HTML attribute order for checkbox field and label-placement cases. |
| tests/Field/CheckboxListTest.php | Updates expected HTML attribute order for checkbox list rendering. |
| tests/Field/RadioListTest.php | Updates expected HTML attribute order for radio list rendering. |
| tests/Field/SubmitButtonTest.php | Updates expected HTML attribute order for submit button with custom button tag. |
| tests/Field/Base/InputFieldTest.php | Updates expected HTML attribute order for base input field behavior. |
| tests/Field/Base/DateTimeInputFieldTest.php | Updates expected HTML attribute order for base datetime input field. |
| tests/Field/Base/ButtonFieldTest.php | Updates expected HTML attribute order for base button field behavior. |
| tests/Field/Base/PartsFieldTest.php | Updates expected HTML attribute order for container part attributes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.