Conversation
Member
vjik
commented
Jun 13, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | - |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
============================================
+ Coverage 99.49% 99.53% +0.03%
- Complexity 141 152 +11
============================================
Files 8 10 +2
Lines 394 427 +33
============================================
+ Hits 392 425 +33
Misses 2 2 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Jun 13, 2024
| - New #108: Support of nested values in message templates' variables, e. g. `{foo.bar}` (@vjik) | ||
| - Bug #89: Fix error on parse messages, that contains variables that cannot cast to a string (@vjik) | ||
| - New #109: Add context enricher (@vjik) | ||
| - Chg #109: Deprecate `Logger` methods `setTraceLevel()` and `setExcludedTracePaths()` in favor of context enricher |
Member
Author
There was a problem hiding this comment.
Currently README don't contain information about this methods.
Member
Author
There was a problem hiding this comment.
Yes. Bun I think it should be in separated section "Context providers".
samdark
reviewed
Jun 14, 2024
Comment on lines
+26
to
+28
| foreach ($this->providers as $provider) { | ||
| $context = array_merge($context, $provider->getContext()); | ||
| } |
Member
There was a problem hiding this comment.
samdark
approved these changes
Jun 14, 2024
samdark
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.