Skip to content

Add ext-psr to conflict section in composer.json#127

Merged
samdark merged 3 commits intomasterfrom
copilot/add-ext-psr-to-composer
Dec 5, 2025
Merged

Add ext-psr to conflict section in composer.json#127
samdark merged 3 commits intomasterfrom
copilot/add-ext-psr-to-composer

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 2, 2025

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #126

The PECL psr extension (https://pecl.php.net/package/psr) provides PSR interfaces for PHP but is built against psr/log 1.0.0. This library requires psr/log ^2.0 || ^3.0, causing interface conflicts when both are present.

Added ext-psr to the conflict section so Composer warns users of the incompatibility:

"conflict": {
    "ext-psr": "*"
}

Also added changelog entry under version 2.1.2.

Original prompt

This section details on the original issue you should resolve

<issue_title>Add ext-psr to "conflict" section in composer.json</issue_title>
<issue_description>The psr PHP extension is designed to work with psr/log version 1.0.0, but Yii Log works with psr/log version 2 or higher.

PECL page: https://pecl.php.net/package/psr
Extension repo: https://github.com/jbboehr/php-psr</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ext-psr to conflict section in composer.json Add ext-psr to conflict section in composer.json Dec 2, 2025
Copilot AI requested a review from samdark December 2, 2025 07:35
@vjik
Copy link
Copy Markdown
Member

vjik commented Dec 2, 2025

Don't forget add line to changelog

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.55%. Comparing base (67805eb) to head (da89e3e).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
- Coverage     99.56%   99.55%   -0.02%     
  Complexity      161      161              
============================================
  Files            11       11              
  Lines           464      448      -16     
============================================
- Hits            462      446      -16     
  Misses            2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark
Copy link
Copy Markdown
Member

samdark commented Dec 4, 2025

@copilot add line to CHANGELOG describing the change.

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Dec 4, 2025

@copilot add line to CHANGELOG describing the change.

Added changelog entry in commit da89e3e.

@samdark samdark marked this pull request as ready for review December 4, 2025 19:02
@samdark samdark requested review from Copilot and vjik December 4, 2025 19:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ext-psr PECL extension to the conflict section in composer.json to prevent compatibility issues. The PECL psr extension is built against psr/log 1.0.0, while this library requires psr/log ^2.0 || ^3.0, causing interface conflicts when both are present.

Key Changes

  • Added ext-psr: "*" to the conflict section in composer.json
  • Updated CHANGELOG.md with an entry documenting this change under version 2.1.2

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
composer.json Adds new conflict section declaring incompatibility with ext-psr extension
CHANGELOG.md Documents the conflict addition with proper issue reference and attribution

The implementation looks correct. The conflict section is properly formatted and positioned in the composer.json file, and the changelog entry follows the project's established format. No issues were identified in the changes.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samdark samdark merged commit ce46a3b into master Dec 5, 2025
57 of 58 checks passed
@samdark samdark deleted the copilot/add-ext-psr-to-composer branch December 5, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ext-psr to "conflict" section in composer.json

4 participants