Skip to content

Chore: Split ServerAPI into smaller pieces #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iLLiCiTiT merged 54 commits into from
Aug 28, 2025
Merged

Chore: Split ServerAPI into smaller pieces #266

iLLiCiTiT merged 54 commits into from
Aug 28, 2025

Conversation

@iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 14, 2025

Changelog Description

Split ServerAPI class into smaller pieces.

Additional review information

Help to organize the functionality and help IDEs to avoid crashes. Before this PR server_api.py had over 9K of lines.

Added annotations import from __future__ to be able to use list and dict type-hints.

Testing notes:

  1. All should be working as before this PR.

iLLiCiTiT added 30 commits August 12, 2025 14:21
@iLLiCiTiT
added more methods to base class
5f562ab
@iLLiCiTiT
moved request type to utils
1d5ef25
@iLLiCiTiT
moved addons logic to separate class
8d33597
@iLLiCiTiT
add addons api to automated api
b9011f8
@iLLiCiTiT
updated order of functions in public api
ee6ec10
@iLLiCiTiT
move 'fill_own_attribs' to utils
4daab3e
@iLLiCiTiT
added more black magic
f04edad
@iLLiCiTiT
change imports in init
1e94982
@iLLiCiTiT
separated project methods
ac96f87
@iLLiCiTiT
added annotations imports
bbd75df
@iLLiCiTiT
move links to separate file
ec23b65
@iLLiCiTiT
move more methods related to projects
186bc36
@iLLiCiTiT
change order of api functions
4841222
@iLLiCiTiT
change links order
f1114ae
@iLLiCiTiT
move 'prepare_list_filters' to utils
41890a0
@iLLiCiTiT
define 'ServerVersion' type
531b95e
@iLLiCiTiT
implement 'get_rest_entity_by_id'
eaf901e
@iLLiCiTiT
move folders to separate class
ec5f5e6
@iLLiCiTiT
moved events api to separate file
f02e25c
@iLLiCiTiT
moved activities api
a34be6f
@iLLiCiTiT
move few things to utils
f876275
@iLLiCiTiT
move thumbnails api to separate file
462f9e2
@iLLiCiTiT
moved workfiles info into separate file
f00f4e6
@iLLiCiTiT
moved representations api to separate file
14b56b7
@iLLiCiTiT
moved tasks, products and versions
11ba7d8
@iLLiCiTiT
use set, list and dict for typehints
81729e3
@iLLiCiTiT
use list, dict and set in typing too
dc058e0
@iLLiCiTiT
updated typehints in public api
99df5d9
@iLLiCiTiT
added get_site_id to base
815eccc
@iLLiCiTiT
removed unused imports
200574f
@iLLiCiTiT iLLiCiTiT self-assigned this Aug 14, 2025
@iLLiCiTiT iLLiCiTiT added the type: enhancement New feature or request label Aug 14, 2025
@iLLiCiTiT iLLiCiTiT requested review from antirotor and kalisp August 14, 2025 09:49
@iLLiCiTiT iLLiCiTiT requested a review from BigRoy August 18, 2025 14:28
antirotor
antirotor reviewed Aug 27, 2025
View reviewed changes
antirotor
antirotor approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit it is difficult to go through. I've ran tests and they are passing. So lets merge it!

@iLLiCiTiT iLLiCiTiT merged commit b06f48d into develop Aug 28, 2025
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/171-split-ayon-python-api branch August 28, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antirotor antirotor antirotor approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@BigRoy BigRoy Awaiting requested review from BigRoy

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

type: enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iLLiCiTiT @antirotor