Operations: Add type hints #268
Conversation
antirotor
left a comment
antirotor
left a comment
There was a problem hiding this comment.
Things to consider - using TypedDict to construct return values and how to deal with NOT_SET - perhaps changing NOT_SET and similar to class and type hint that?
| folder_id: str, | ||
| name: Optional[str] = None, | ||
| folder_type: Optional[str] = None, | ||
| parent_id: Optional[str] = NOT_SET, |
There was a problem hiding this comment.
This won't work as NOT_SET is object, but the attribute is typed as Optional[str].
There was a problem hiding this comment.
And what would be the solution? How to type-hint placeholder objects?
The type-hint for "developer using the code" is Optional[str] if he passes the value. I really don't want to block this PR just because it is not mypy compatible, the release of python api should have been done 2 weeks ago.
There was a problem hiding this comment.
Not functional change, should not block the merge anyway. Would be nice to find how to solve that though.
Changelog Description
Fill type hints in operations code.
Testing notes: