GraphQl base: Added type-hints #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I am seeing: |
Member
Author
|
Should be fixed. |
antirotor
approved these changes
Sep 8, 2025
Member
antirotor
left a comment
antirotor
left a comment
There was a problem hiding this comment.
Looks good for signatures. Mypy is complaining about missing type hints inside the code and there are some issues about incompatible assignments, not much but still. I guess topic for different PR
kalisp
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Added type hints to graphql base api.
Additional review information
It helped to discover few issues in the code (luckily the code was never triggered).
Testing notes:
get_folders,get_tasks,get_activitiesetc.