This repository was archived by the owner on May 22, 2025. It is now read-only.
Makes the SM surge event even more powerful #11464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patpol4
added
Balance
Contributor
Author
|
Would be nice to at least get this testmerged to see if I'm not a giant idiot and got this all wrong. |
|
More power = good |
Contributor
Author
|
Ok it turns out I am, the values should still be fine though. |
alexkar598
suggested changes
May 13, 2021
| name = "Supermatter Surge" | ||
| typepath = /datum/round_event/supermatter_surge | ||
| weight = 20 | ||
| weight = 15 |
Contributor
Author
There was a problem hiding this comment.
its in the description but i did the changelog too now
alexkar598
reviewed
May 13, 2021
|
|
||
| /datum/round_event/supermatter_surge/setup() | ||
| power = rand(400,8000) | ||
| power = rand(1000,100000) |
Member
There was a problem hiding this comment.
Thats a very wide range, this will lead to inconsistent gameplay.
Contributor
Author
There was a problem hiding this comment.
Yes and the severity is going to be stated in the announcement so it's not like it's secret and people don't realize how bad it is.
Do you think i should raise the minimum?
alexkar598
suggested changes
May 13, 2021
| power = rand(1000,100000) | ||
|
|
||
| /datum/round_event/supermatter_surge/announce() | ||
| if(power > 800 || prob(round(power/8))) |
Member
There was a problem hiding this comment.
- Both these conditions are redundant as the power will never be under 800 and the prob will never fail as the minimum is 1000/8 so prob(125).
- The class number can be ridiculously high now. Anywhere from class 3 to class 201
Contributor
Author
There was a problem hiding this comment.
- removed the condition so it always announces,
- yes
|
Yessssssssss |
Yogbot-13
pushed a commit
that referenced
this pull request
May 21, 2021
Yogbot-13
pushed a commit
that referenced
this pull request
May 25, 2021
Closed
Yogbot-13
added a commit
that referenced
this pull request
Jun 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Documentation
Intent of your Pull Request
After the latest changes it's still wet farts. What I did is raise the maximum random powerup to as high as 100 000.
This may seem like a lot compared to what we have now(8k) but from what I understand, the way this code works is just set it to the power value for a split second, making even values up to 10k insignificant on a default engine setup.
Made it a bit more rare to balance it out.
Tested it by getting a simple straight pipe setup and setting the SM power level to 100k via varediting. What happened was it just burned for a little while but didn't even start delaminating.
Why is this change good for the game?
As it is right now it still does nothing and only fills up the events.
Wiki Documentation
Briefly describe your PR and the impacts of it, in layman's terms.
What I did is raise the maximum random powerup to as high as 100 000.
This may seem like a lot compared to what we have now(8k) but from what I understand, the way this code works is just set it to the power value for a split second, making even values up to 10k insignificant on a default engine setup.
Made it a bit more rare to balance it out.
What should players be aware of when it comes to the changes your PR is implementing?
The SM surge event is now a bit more rare but more powerful
What general grouping does this PR fall under?
Engineering
Are there any aspects of the PR that you would like us not to mention on the Wiki?
Not really
If there are any numerical values involved in your PR that will be relevant to a player, please note them here.
The earliest start for it is 10 minutes in and the SM crystal has to has been powered.
Changelog
🆑
tweak: Makes the SM surge event even more powerful, lowers its chance to appear
/:cl: