Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@alexkar598
Copy link
Member

@alexkar598 alexkar598 commented May 28, 2021

Let's end this stupid shit of admins bwoinking people for making use of cryo pods as they should be used because of a bug

Technical details:
Alert will return the first option automatically if the mob does not have a client set, this made people autoconsent to ghost, which was a bug
Also moved the ghost prompt down so it starts the despawn timer before asking people if thye wanna take control but that despawn timer is cancelled if the person says yes

🆑
bugfix: You can no longer offer people to ghosts by cryoing them forcibly, players who cryo themselves are still able to offer themselves
bugfix: You can no longer delay the cryo despawn timer indefinetly by keeping the offer to ghost prompt open indefinetly
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label May 28, 2021
@alexkar598
Copy link
Member Author

Actually lemme reopen this as an admin pr

@alexkar598 alexkar598 closed this May 28, 2021
@alexkar598 alexkar598 changed the title People who are non consentually put into cryo no longer get offered to ghosts automatically and prevents using cryo as an indestructible safe spot by using the offer to ghost prompt to delay the cryo forever [Admin] People who are non consentually put into cryo no longer get offered to ghosts automatically and prevents using cryo as an indestructible safe spot by using the offer to ghost prompt to delay the cryo forever May 28, 2021
@alexkar598 alexkar598 reopened this May 28, 2021
@alexkar598
Copy link
Member Author

Also turdis is failing but thats because of dependency funny

@Bibby0110
Copy link
Contributor

Also turdis is failing but thats because of dependency funny

funny way to say "my code is broken"

@adamsong
Copy link
Contributor

adamsong commented Jun 3, 2021

Will this still offer those with no ckey?

@MegaEmpirical
Copy link

So will bodies still be deleted? What's the timer?

@alexkar598
Copy link
Member Author

Will this still offer those with no ckey?

Only those who are online will get the prompt, if you are not online, you do not get offered, if you are online, you get to choose. So no.

So will bodies still be deleted? What's the timer?

5 minutes if you're offline when youre put in cryo, 30 seconds otherwise.

@MegaEmpirical
Copy link

I would rather it be made so that no player can cryo another

@Firewolf34
Copy link
Contributor

I would rather it be made so that no player can cryo another

Why is that? The purpose of cryo is to get SSD people out of the halls... random people going SSD instead of going to dorms (if they want to stay in the game) or going to cryo (if they wish to leave) is a nuisance - so we carry them to cryo so the system can deal with them. If anything, we should have this happen automatically somehow. Maybe get a borg to do it.

@patpol4
Copy link
Contributor

patpol4 commented Jun 8, 2021

This offers me even when I press no I dont want to offer myself, I just want to cryo

@patpol4
Copy link
Contributor

patpol4 commented Jun 9, 2021

#11561

@JamieD1 JamieD1 merged commit de7124c into master Jun 13, 2021
@JamieD1 JamieD1 deleted the alexkar598-patch-9 branch June 13, 2021 10:25
Yogbot-13 added a commit that referenced this pull request Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants