Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@maxion12345
Copy link
Contributor

@maxion12345 maxion12345 commented Jul 4, 2021

PORT: BeeStation/BeeStation-Hornet#2432
BUT I CHANGED IT

General Documentation

Intent of your Pull Request

Adds the AtmosBot! A robot designed to BLOW ITSELF UP OVER ANY HOLES IN THE FLOOR

BEHOLD MY CODERSPRITE

Simple recipe: robot arm, smartmetal grenade, prox sensor, analyzer

When emagged, it'll fucking explode instead of spewing foam

Why is this change good for the game?

Variety is the spice of life. Also, suicide foam bot work better

Wiki Documentation

The recipe is cyborg arm onto analyzer, then grenade onto that assembly, then prox sensor onto that.

Briefly describe your PR and the impacts of it, in layman's terms.

Roboticists will need an updated wiki page to reflect the new robot

What should players be aware of when it comes to the changes your PR is implementing?

see above

What general grouping does this PR fall under?

add

Are there any aspects of the PR that you would like us not to mention on the Wiki?

If there are any numerical values involved in your PR that will be relevant to a player, please note them here.

Each bot can only deploy (1) holofan, and will stay near the holofan until the breach is repaired.

Changelog

Edit this changelog for changes that are noticeable by the players. Remove it if this isn't the case. If you add a name after the ':cl', that name will be used in the changelog. Leave it empty to use your GitHub name. Prefix the PR title with [admin] if it's something admin related. Prefix the PR title with [s] if you are fixing an exploit so it is not announced on discord and the server.

🆑 PowerfulBacon & Wuba
rscadd: Ported the Atmosbot from Beestation! Modified for Yogurt station, these robots are foam grenades with legs and will seal breaches or die trying
/:cl:

@maxion12345 maxion12345 requested a review from a team as a code owner July 4, 2021 22:21
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Sprites This PR has spriting changes labels Jul 4, 2021
@Cartlord
Copy link
Contributor

Cartlord commented Jul 4, 2021

These seem quite ridiculously strong for Yogs, IMO; I think they fit Bee more, since over there it's a genuine possibility that nobody knows how to un-fuck Atmos - but here, we usually have at least someone able to fix a breach.
EDIT: Also, what's to stop Cargo Techs from using an EMagged Atmosbot in Yet Another Miasma Farm Setup? Might wanna replace that with a deadlier gas (BZ maybe? Though that could also be abused by Atmos) rather than a mild inconvenience.

@maxion12345
Copy link
Contributor Author

These seem quite ridiculously strong for Yogs, IMO; I think they fit Bee more, since over there it's a genuine possibility that nobody knows how to un-fuck Atmos - but here, we usually have at least someone able to fix a breach.
EDIT: Also, what's to stop Cargo Techs from using an EMagged Atmosbot in Yet Another Miasma Farm Setup? Might wanna replace that with a deadlier gas (BZ maybe? Though that could also be abused by Atmos) rather than a mild inconvenience.

Nah, they aren't super strong. Remember, each bot can only deploy one holofan so you need at minimum four to seal a 1x1 breach. And while sealing breaches they'll be unable to refill rooms. The miasma farm emagged bot is an interesting idea, but gas exports were nerfed after everyone in their mother did one. In addition, emags are contraband and technically weapons under the new space law, so if security hands one over to cargo then admins gonna get salty.

@stwordcitizen
Copy link
Contributor

Less work that atmos can do, therefor less reason to play the role if your not planning on doing autism projects in atmos.

@UselessTheremin
Copy link
Contributor

these sprites are really gross

@maxion12345
Copy link
Contributor Author

Less work that atmos can do, therefor less reason to play the role if your not planning on doing autism projects in atmos.

when the fuck does atmos repair breaches anyways, its always engineering

these sprites are really gross

codersprites

@maxion12345
Copy link
Contributor Author

anyways, these bots aren't meant to replace the job of atmos techs. They don't fix breaches, they can't undo plasmafires, and you need a bunch of them to handle any breaches bigger than a 1x1. Just a neat robot that works together with other robots to accomplish a bigger task

@Cartlord
Copy link
Contributor

Cartlord commented Jul 5, 2021

They can kind-of undo a fire on their own though, just takes a while. They scrub the bad fire gas and stabilize temperature.

Copy link
Contributor

@nesisknesis nesisknesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

also original author's name here so they get credited in the changelog
image

@MegaEmpirical
Copy link

In addition, emags are contraband and technically weapons under the new space law, so if security hands one over to cargo then admins gonna get salty.

Emags are tools, not wewpons.

@maxion12345
Copy link
Contributor Author

In addition, emags are contraband and technically weapons under the new space law, so if security hands one over to cargo then admins gonna get salty.

Emags are tools, not wewpons.

aha, but you can emag a preternis to disable them, thusly making them a weapon under the new space law

@MegaEmpirical
Copy link

In addition, emags are contraband and technically weapons under the new space law, so if security hands one over to cargo then admins gonna get salty.

Emags are tools, not wewpons.

aha, but you can emag a preternis to disable them, thusly making them a weapon under the new space law

I am telling you they're tools.

@maxion12345
Copy link
Contributor Author

In addition, emags are contraband and technically weapons under the new space law, so if security hands one over to cargo then admins gonna get salty.

Emags are tools, not wewpons.

aha, but you can emag a preternis to disable them, thusly making them a weapon under the new space law

I am telling you they're tools.

@maxion12345
Copy link
Contributor Author

ah fuck I hit the wrong button

@maxion12345 maxion12345 reopened this Jul 10, 2021
@JamieD1
Copy link
Contributor

JamieD1 commented Jul 18, 2021

Feels extremely overpowered @SomeguyManperson

Copy link
Contributor

@Bibby0110 Bibby0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look through the rest honk

@maxion12345
Copy link
Contributor Author

maxion12345 commented Jul 19, 2021

I changed the two "time =" i found to the SECONDS format. Crafting time has been increased to six seconds to be in line with other "complex" bots (ED209, Securitron). For reference, the other bots are 4 seconds. If you guys think its too overpowered, we can change it just to seal breaches, seeing as with monstermos the vents can do most of the work refilling a room.

@JamieD1 JamieD1 added the TESTMERGED This PR is currently live in a test merge. label Jul 24, 2021
@maxion12345
Copy link
Contributor Author

@JamieD1 this gonna get testmerged?

@maxion12345
Copy link
Contributor Author

These bots are just a neat addition to the game, even if they don't really do much. I wonder if I can make some voice lines for them.

@maxion12345
Copy link
Contributor Author

notes so far:
they work pretty well, and can be mass produced easily.

thats when they actually can reach the breach, sometimes they just stop for no reason mid-movement and refuse to take another step. thinking maybe of making a smart metal grenade bot that is a single-use suicide bomber on wheels that is crafted with a scooter, proximity sensor, and a smart metal grenade, that just wheels itself to the breach then blows itself up to foam it

@JamieD1
Copy link
Contributor

JamieD1 commented Aug 26, 2021

@maxion12345 can you make them cover a breach with barriers? right now they place one barrier then give up..

@maxion12345
Copy link
Contributor Author

@JamieD1
new suicide bot with codersprite is completed

@adamsong
Copy link
Contributor

Check linter please

@maxion12345
Copy link
Contributor Author

Check linter please

linter is green now

@maxion12345
Copy link
Contributor Author

after 2 months in development i hope its been worth the wait

@JamieD1
Copy link
Contributor

JamieD1 commented Aug 30, 2021

Will testmerge and see if its not shit.

@Bibby0110
Copy link
Contributor

I don’t think it needs to be called an ASSBot

@maxion12345
Copy link
Contributor Author

I don’t think it needs to be called an ASSBot

because its funny

@adamsong adamsong removed the TESTMERGED This PR is currently live in a test merge. label Sep 12, 2021
@adamsong adamsong added the TESTMERGED This PR is currently live in a test merge. label Sep 20, 2021
@JamieD1 JamieD1 requested a review from nesisknesis September 20, 2021 23:33
@adamsong adamsong added the Test Merge - Scheduled This PR is waiting to be test merged label Oct 10, 2021
Yogbot-13 added a commit that referenced this pull request Oct 10, 2021
Yogbot-13 added a commit that referenced this pull request Oct 14, 2021
@SomeguyManperson SomeguyManperson merged commit 41e58e7 into yogstation13:master Oct 15, 2021
Yogbot-13 added a commit that referenced this pull request Oct 15, 2021
@maxion12345 maxion12345 deleted the atmosbot branch October 16, 2021 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Sprites This PR has spriting changes Test Merge - Scheduled This PR is waiting to be test merged TESTMERGED This PR is currently live in a test merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.