This repository was archived by the owner on May 22, 2025. It is now read-only.
Hopefully makes diagonal movement faster. #11720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This makes all movement significantly faster. I don't like that... Besides, diagonal movement is supposed to be slower since it's traveling two tiles at once |
Contributor
|
Please do not do this |
Contributor
It does not
Why? All it does it make it so the delay is appropriate for the actual distance you travel |
Author
|
The delay should be exactly equivalent to walking in a cardinal direction. |
JamieD1
approved these changes
Jul 24, 2021
Yogbot-13
added a commit
that referenced
this pull request
Jul 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Documentation
Intent of your Pull Request
Ports this PR. My private server lagged, but I don't think it was because of smooth diagonal movement.
Why is this change good for the game?
The movement delay for going diagonally was set to an arbitrary 2x multiplier. The actual multiplier should be sqrt(2), which is ~1.4
Wiki Documentation
Briefly describe your PR and the impacts of it, in layman's terms.
Faster diagonal movement.
What should players be aware of when it comes to the changes your PR is implementing?
As much as I hate repeating the same thing for every part of this template, faster diagonal movement.
What general grouping does this PR fall under?
Movement tweaks.
If there are any numerical values involved in your PR that will be relevant to a player, please note them here.
The movement delay uses 1.414214 now. What does this mean? I don't really know.
Changelog
Edit this changelog for changes that are noticeable by the players. Remove it if this isn't the case. If you add a name after the ':cl', that name will be used in the changelog. Leave it empty to use your GitHub name. Prefix the PR title with [admin] if it's something admin related. Prefix the PR title with [s] if you are fixing an exploit so it is not announced on discord and the server.
🆑
tweak: diagonal movement is faster now
/:cl: