Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@adamsong
Copy link
Contributor

@adamsong adamsong commented Aug 9, 2021

Github documenting your Pull Request

The bridge fire axe cabinet, and spare ID cabinet will now have captain access, instead of atmos tech access.

Changelog

🆑
bugfix: fixed the access on the spare ID cabinet
bugfix: fixed the access on the bridge fire axe cabinet
/:cl:

@adamsong adamsong requested a review from a team as a code owner August 9, 2021 03:00
@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. labels Aug 9, 2021
@Firewolf34
Copy link
Contributor

Hi - I was the author of the commit that gave the Fireaxe Cabinet access restrictions back in 2019 with PR 4561 - Fireaxe Cabinet Improvements.

Wanted to give context. The reason that the Fireaxe Cabinet has Atmos Tech access is so that Chief Engineer and Atmospherics Techs (and Captain, I suppose by proxy) can use them for firefighting duty. But I understand why it would be smart to keep the Fireaxe at Bridge for command staff only given that it can be used to break into other Bridge areas. I think the reason that the Spare ID ever had Atmos Access is due to someone blindly deriving from the Fireaxe Cab and forgetting to change it, perhaps?

@maxion12345
Copy link
Contributor

Hi - I was the author of the commit that gave the Fireaxe Cabinet access restrictions back in 2019 with PR 4561 - Fireaxe Cabinet Improvements.

Wanted to give context. The reason that the Fireaxe Cabinet has Atmos Tech access is so that Chief Engineer and Atmospherics Techs (and Captain, I suppose by proxy) can use them for firefighting duty. But I understand why it would be smart to keep the Fireaxe at Bridge for command staff only given that it can be used to break into other Bridge areas. I think the reason that the Spare ID ever had Atmos Access is due to someone blindly deriving from the Fireaxe Cab and forgetting to change it, perhaps?

thats exactly why it had that access probably maybe yes
and never was an issue because captains have all access

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants