Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@nmajask
Copy link
Contributor

@nmajask nmajask commented Aug 18, 2021

Github documenting your Pull Request

So, this PR ports and adds some tweaks and fixes for the crew monitor. The fixes are all ports while the appearance changes are by me. Most of this has been tested, but there may be some stuff I missed.

Ports

Changes by Me

I also changed some stuff with the crew monitor to look better and fix a few issues I had with my original PR

  • Moved assistants so they come after the other civilian jobs
  • Changed the color for civilian jobs to be lighter (#b4b4b4) to help it better stand out from the background
  • Changed the cargo color to a color that was more brown (#d4680d) to help it not blend in with engineering
  • Shrank the window (1400x800 to 1000x800) to remove some of the unused space left by the removal of the map

What Does it Look Like Now?

image

Here is an image showing many of the changes

Wiki Documentation

As long as the UI for the crew monitor isn't show on the wiki (which I don't think it is) there should be no needed changes.

Changelog

🆑 MacBlaze1, Cenrus, nichlas0010, nmajask
bugfix: fixed ghosts not being able to view crew monitors
bugfix: fixed the crew monitor vital square not taking into account burn damage
bugfix: potentially fixed random duplicate unknowns of people appearing on the crew monitor
tweak: tweaked the appearance of the crew monitor UI
/:cl:

Ports and adds some fixes for the crew monitor
@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Javascript This PR contains javascript code. Tweak This PR contains changes to the game. labels Aug 18, 2021
@github-actions github-actions bot added the tgui This PR affects TGUI label Aug 18, 2021
@JamieD1
Copy link
Contributor

JamieD1 commented Aug 19, 2021

How about we fix the map :D

@SomeguyManperson SomeguyManperson merged commit 16913e5 into yogstation13:master Aug 20, 2021
Yogbot-13 added a commit that referenced this pull request Aug 20, 2021
SomeguyManperson pushed a commit that referenced this pull request Aug 21, 2021
 (#12093)

* "fixes" stuff

removes some code

* fixes for my "fix"

aaaaaaaaaaaa

* will this fix it?

aaaaaaaaa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs Javascript This PR contains javascript code. tgui This PR affects TGUI Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants