Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@nesisknesis
Copy link
Contributor

@nesisknesis nesisknesis commented Aug 31, 2021

Github documenting your Pull Request

Puts the old cloak and Kor's new cloaks into a single set made by me

image

image
image
image
image
image
image
image

I think this breathes fresh new designs into the cloaks, problems with the originals (2011) we're that colours were quite dark and dull, especially in the captain's cloak. The new designs made by myself introduce hue-shifting which tends to make colours more appealing and fuller. Furthermore, some designs like the RD's I thought were pretty lacking so they went through a re-design. As for Kor's sprites, people were generally not enthused about them, so token details from them we're also added to the new ones.

I have attempted to retain much design from the original cloaks and details from Kor's into what I think to be a modern version of cloaks.

Cloaks also now aren't blocked by backpacks.

Wiki Documentation

your wiki challenge

Changelog

🆑 Identification, Kor
imageadd: Unifies both the old cloaks and recently added new cloaks into a single set of cloaks.
tweak: Backpacks don't appear over the top of cloaks
/:cl:

@nesisknesis nesisknesis requested a review from a team as a code owner August 31, 2021 22:57
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Sprites This PR has spriting changes Tweak This PR contains changes to the game. labels Aug 31, 2021
@N3D6
Copy link
Contributor

N3D6 commented Aug 31, 2021

Color on the CE one is bad

@ToasterBiome
Copy link
Contributor

ToasterBiome commented Aug 31, 2021

The only thing I don't like about them is how you tweaked the colors for the cloaks

Shouldn't a person that knows the fundamentals know that the colors look, as you say, "dogshit" on the heads because of subtle difference in clothing colors vs the cloaks? At least the 2011 are faithful to their colors.

Amazing spritework, you're a force to be reckoned with, I just think the colors can use some work. Never sat with me that they're sliiiiightly different to be noticable.

if these get merged i'd like to see the colors of the head clothes changed to match the new cloaks, at least. Great work.

@Reed0506
Copy link

while i really like the old 2011 cloaks, your new ones are very good and i would not be mad to see them permanently swapped to your designs. RD cloak feels a bit too purple to me but i guess thats just because the old one has so little.

@nesisknesis
Copy link
Contributor Author

The only thing I don't like about them is how you tweaked the colors for the cloaks

Shouldn't a person that knows the fundamentals know that the colors look, as you say, "dogshit" on the heads because of subtle difference in clothing colors vs the cloaks? At least the 2011 are faithful to their colors.

Amazing spritework, you're a force to be reckoned with, I just think the colors can use some work. Never sat with me that they're sliiiiightly different to be noticable.

if these get merged i'd like to see the colors of the head clothes changed to match the new cloaks, at least. Great work.

Yes you are correct, I am aware that there is a lot of clashing with colours, however, all colours used for my cloaks have been hue-shifted which I believe makes them more superior to the original colours used. I'll provide an example.

image

My process is to introduce these higher quality sprites so that they can be "leap-frogged" off of by other people to improve the other sprites that are used. IE. taking the palette from the cloak. With this though, it'll look dodgy in the early stages but hopefully later on things should start to become consistent while also higher quality; it's like a platform if you get my meaning.

The captain cloak I think is a special case since I had updated some of the captain's clothing beforehand so the Captain's cloak likely looks more consistent than the original did.

As for updating the head's clothing, for it to fully take advantage of the palette, it may need a sprite update. though I may take it into consideration. Right now I like to focus on single projects, and that project is security currently

@ToasterBiome
Copy link
Contributor

Well said, hopefully you get to the heads clothes soon. 👍

@JamieD1 JamieD1 added the On hold - HD Should not be merged without HD Approval label Sep 1, 2021
@adamsong
Copy link
Contributor

adamsong commented Sep 1, 2021

They still look excessively baggy on the shoulders

@nesisknesis
Copy link
Contributor Author

nesisknesis commented Sep 1, 2021

Sorry if I sound arrogant in the (pre-edited) description of this PR, i'm used to obstinent comments of keeping originals for keepsake and was also expecting 7 downvotes instead of 7 upvotes so i'm pretty surprised and uplifted that there is the polar opposite. in light of this, i'm pretty grateful, especially so since theres are many cases of outright rejection in other codebases

@JamieD1
Copy link
Contributor

JamieD1 commented Sep 4, 2021

Sorry if I sound arrogant in the (pre-edited) description of this PR, i'm used to obstinent comments of keeping originals for keepsake and was also expecting 7 downvotes instead of 7 upvotes so i'm pretty surprised and uplifted that there is the polar opposite. in light of this, i'm pretty grateful, especially so since theres are many cases of outright rejection in other codebases

See comments in discord

@Firewolf34
Copy link
Contributor

Sorry if I sound arrogant in the (pre-edited) description of this PR, i'm used to obstinent comments of keeping originals for keepsake and was also expecting 7 downvotes instead of 7 upvotes so i'm pretty surprised and uplifted that there is the polar opposite. in light of this, i'm pretty grateful, especially so since theres are many cases of outright rejection in other codebases

Yeah that phenomenon is so common with spritework changes unfortunately (regardless of game/codebase/whatever). excellent work on these :) now you just gotta do the rest of the game.

@JamieD1 JamieD1 changed the title Unifies the cloaks into one set and I explain why Unifies the cloaks Sep 17, 2021
@SomeguyManperson SomeguyManperson added the TESTMERGED This PR is currently live in a test merge. label Sep 30, 2021
@adamsong adamsong added the Test Merge - Scheduled This PR is waiting to be test merged label Oct 10, 2021
Yogbot-13 added a commit that referenced this pull request Oct 10, 2021
Yogbot-13 added a commit that referenced this pull request Oct 14, 2021
Yogbot-13 added a commit that referenced this pull request Oct 18, 2021
Yogbot-13 added a commit that referenced this pull request Oct 31, 2021
@rebaia rebaia mentioned this pull request Nov 3, 2021
Yogbot-13 added a commit that referenced this pull request Nov 14, 2021
@SomeguyManperson SomeguyManperson added Merge conflict Files are conflicting with current live changes. and removed TESTMERGED This PR is currently live in a test merge. labels Nov 15, 2021
@JamieD1 JamieD1 enabled auto-merge (squash) November 27, 2021 15:18
@adamsong adamsong added the Stale I'm closing this in like a week if you don't push a new commit label Dec 6, 2021
@adamsong
Copy link
Contributor

Reopen when the conflict is fixed

@adamsong adamsong closed this Dec 12, 2021
auto-merge was automatically disabled December 12, 2021 12:34

Pull request was closed

@nesisknesis nesisknesis reopened this Dec 15, 2021
@nesisknesis nesisknesis removed Merge conflict Files are conflicting with current live changes. Stale I'm closing this in like a week if you don't push a new commit Test Merge - Scheduled This PR is waiting to be test merged On hold - HD Should not be merged without HD Approval labels Dec 15, 2021
@adamsong adamsong enabled auto-merge (squash) December 15, 2021 16:21
@adamsong adamsong merged commit 84f6633 into yogstation13:master Dec 15, 2021
Yogbot-13 added a commit that referenced this pull request Dec 15, 2021
nesisknesis added a commit that referenced this pull request Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DME Edit This PR affects the yogstation.DME file Sprites This PR has spriting changes Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants