Forces the mirror shield to unbuckle it's victims

[Notamaniac]

Document the changes in your pull request

Closes #12380

If two people are buckled next to each other, the mirror shield will bounce off each other indefinitely, causing massive damage. This will still happen if the victims are cuffed and buckled, but eh.

Wiki Documentation

None

Changelog

🆑
tweak: The mirror shield will attempt to unbuckle the victim it's thrown at, then launch itself. This stops the mirrorshield from insta-killing two people buckled together, however if they're bucklecuffed it's still instadeath.
/:cl:

[Reed0506]

i feel a better solution would be to set a hard limit on how many times it can bounce

[Notamaniac]

i feel a better solution would be to set a hard limit on how many times it can bounce

That might creep into balance territory, and wouldn't solve the core issue of buckling two people together and getting in multiple hits on one person, even if the hard limit was set down to 3/4. (Right now recursion code stops the bounces at 8 soo...)

The another solution might be to keep a var tracking the last two people the shield hit, and if the shield were to target one of those people, stop bouncing. But that might run into some edge cases (what if 3 people are in the same area?)

Alternatively the shield could keep the list of people it hit and work off that, but I don't know enough byond code to implement that solution cleanly

[Hopekz]

Why does this need a solution? It's very situational and when it happens it's more of a "cool" thing

[Notamaniac]

Why does this need a solution? It's very situational and when it happens it's more of a "cool" thing

Eh someone made an issue about it, and it's not very cool to be on the receiving end of this

[UselessTheremin]

this is definitely a weird solution yeah why not just have limited bounces

[JamieD1]

Sounds like its been abused by a few people. Good enough solution.