Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@SapphicOverload
Copy link
Contributor

@SapphicOverload SapphicOverload commented Feb 13, 2022

Document the changes in your pull request

Say goodbye to this minor inconvenience, and hours of my life.
The PDA will now start in the ID slot with the ID already inserted. Works with most playable jobs. Has been tested. Must be enabled in the game preferences.

Wiki Documentation

No changes needed.

Changelog

🆑
tweak: pda now starts in the id slot with the id inserted for most playable jobs.
tweak: adds an option to the game preferences for whether you want this change or not.
/:cl:

say goodbye to this minor inconvenience, and hours of my life
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Feb 13, 2022
@KillerOrcaCora
Copy link
Contributor

Good Pr you are an angel.

@patpol4
Copy link
Contributor

patpol4 commented Feb 13, 2022

Hugbox

Jobs that start with a PDA somewhere other than the belt slot now work correctly
@ghost
Copy link

ghost commented Feb 13, 2022

Two clicks saved every round. That shit adds up.

prevents everything from breaking if one variable isn't set properly
@JamieD1
Copy link
Contributor

JamieD1 commented Feb 17, 2022

Make it a preference, can help with it.

@SapphicOverload SapphicOverload requested a review from a team as a code owner February 17, 2022 02:26
just in case you hate change, the pda and id will start in the same place as before by default
@bruhlookatthisdood
Copy link
Contributor

halelughija

@JamieD1
Copy link
Contributor

JamieD1 commented Feb 25, 2022

Everyone with this enabled got an ID in a PDA, however no ID if the pref is disabled.

Please test and try again.

also fixes a few other things
Yogbot-13 added a commit that referenced this pull request Mar 7, 2022
@adamsong
Copy link
Contributor

adamsong commented Mar 8, 2022

No one spawned with ids or pda

Copy link
Contributor

@nmajask nmajask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes to yarn

@SapphicOverload
Copy link
Contributor Author

No one spawned with ids or pda

@adamsong i fixed it

Yogbot-13 added a commit that referenced this pull request Mar 13, 2022
@ToasterBiome
Copy link
Contributor

Mining medic was missing their ID, fixed I think

Copy link
Contributor

@nmajask nmajask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the security officer and station engineer files on lines 109 and 82 respectively, you can either use GetID() on the item in the wear_id slot or use get_idcard() on the mob to get the actual ID which would fix ToasterBiome's issue

Yogbot-13 added a commit that referenced this pull request Mar 22, 2022
Yogbot-13 added a commit that referenced this pull request Mar 23, 2022
Yogbot-13 added a commit that referenced this pull request Mar 23, 2022
Yogbot-13 added a commit that referenced this pull request Mar 27, 2022
Yogbot-13 added a commit that referenced this pull request Mar 28, 2022
Yogbot-13 added a commit that referenced this pull request Mar 28, 2022
Yogbot-13 added a commit that referenced this pull request Mar 29, 2022
Yogbot-13 added a commit that referenced this pull request Mar 29, 2022
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People show up twice on PDA sometimes and I think this has something to do with it, will be looking in the coming days for anyone with dual-pda syndrome.

Yogbot-13 added a commit that referenced this pull request Mar 29, 2022
Yogbot-13 added a commit that referenced this pull request Mar 29, 2022
Yogbot-13 added a commit that referenced this pull request Mar 29, 2022
Yogbot-13 added a commit that referenced this pull request Mar 30, 2022
Yogbot-13 added a commit that referenced this pull request Mar 30, 2022
Yogbot-13 added a commit that referenced this pull request Apr 2, 2022
Yogbot-13 added a commit that referenced this pull request Apr 2, 2022
Yogbot-13 added a commit that referenced this pull request Apr 3, 2022
@JamieD1
Copy link
Contributor

JamieD1 commented Apr 3, 2022

People show up twice on PDA sometimes and I think this has something to do with it, will be looking in the coming days for anyone with dual-pda syndrome.

Find anything?

@JamieD1 JamieD1 dismissed stale reviews from ToasterBiome and nmajask April 3, 2022 12:17

Will fix in a post patch if it comes up

@JamieD1 JamieD1 merged commit 05b3295 into yogstation13:master Apr 3, 2022
Yogbot-13 added a commit that referenced this pull request Apr 3, 2022
@SapphicOverload SapphicOverload deleted the pda-in-id-slot branch June 26, 2022 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Awaiting - Action - Author This PR is awaiting an action from the author Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants