Bluespace locker spawns are now more reasonable

[Absolucy]

Document the changes in your pull request

This adds more criteria to bluespace lockers. A bluespace locker candidate must be:

• A non-secure locker (no lock at all on it)
• Not welded, locked, or wall-mounted
• Not in a secure area - generally anywhere sec would immediately be on your ass big-time if you broke into it.
  Here's a general list of banned areas:
  • Security (including checkpoints and armory)
  • Bridge
  • Any Head Office
  • SMES room, gravgen
  • Teleporter
  • Gateway
  • AI satellite
  • Tcomms
  • Virology
  • EVA

Why?

Because the bluespace locker is really fun. You know what's not fun? The damned thing spawning in the one area nobody will ever even look, or in an area like only 2 people have access to (and they certainly won't be looking inside the lockers).

From my experience, bluespace lockers usually result in creativity and fun gimmicks. We need more of that.

Changelog

🆑 Lucy
tweak: The bluespace locker is now more likely to spawn in a generally reasonable area.
/:cl:

[Absolucy]

Changed from an area whitelist to a blacklist.

[Marmio64]

seems unnecessary. This is a multiplayer game, you can ask people if you can check their lockers. If they refuse, well, thats their decision, it allows sec some degree of control over this insanely useful tool then (if its in their department), so whatever. If its in a place that nobody looks, maybe start looking there? Or maybe, you just wont be able to find this really useful thing, it sucks, but it's better to have something be a rare treat you have to work really hard to find then it to be an oversaturated thing you'll get every single round.

[Absolucy]

@Marmio64 Do you even play on the server...?

This is a multiplayer game, you can ask people if you can check their lockers

Do you think anyone will actually care enough to bother checking them for you?

it allows sec some degree of control over this insanely useful tool then

Letting sec have control over it is basically guaranteeing that it will never be used for fun and creativity.

so whatever. If its in a place that nobody looks, maybe start looking there?

OH JEEZ, WHY DIDN'T I THINK OF THAT BEFORE? 🙄

[Marmio64]

@Marmio64 Do you even play on the server...?

This is a multiplayer game, you can ask people if you can check their lockers

Do you think anyone will actually care enough to bother checking them for you?

it allows sec some degree of control over this insanely useful tool then

Letting sec have control over it is basically guaranteeing that it will never be used for fun and creativity.

so whatever. If its in a place that nobody looks, maybe start looking there?

OH JEEZ, WHY DIDN'T I THINK OF THAT BEFORE? 🙄

tons of things on the server are already balanced by requiring cooperation, why should the bluespace locker be any different? Sec would only have control over it in the what, 10% chance it spawns in their department? And, yes, why dont you just look in places where you haven't looked, even if they're in hard to reach places, thats literally what you do. It isn't the games fault that you dont look somewhere just because its harder to get to, its your own fault for not going the extra mile to try to get to it.

[maxion12345]

random locker should be random

[Cartlord]

I like the idea of blackisting it from spawning in some places, but I'm more in favor of keeping it from spawning in some random-ass maints back room that nobody remembers exists or can be bothered to check.

[JamieD1]

Test merged

[Moja10]

This is too much, I would be fine if it was just places like Captain's locker, armory, not this many. A rough estimate I think around 37 lockers are affected by this. Bluespace locker isn't supposed to be something that can be gotten every single round with just exploring common areas like maint or arrivals.

[Absolucy]

@Moja10 Pretty much every single department has qualifying lockers - cargo, science, medbay, the bar, kitchen(?), botany, etc.

[JamieD1]

Change it to Not in High security areas like armoury, captains, teleporter, ai.

Anywhere which is like one door away from public is probably fine. We should encourage people trying to ask to look for it.
We should not be giving it out every single round to the one person who stops doing their job just to do gimmicks with a locker.

[Absolucy]

@JamieD1 Alright. Locked lockers are now candidates, however they're 25% less likely than a locker without an ID lock on it.

[Absolucy]

Well nobody likes this anyways.