This repository was archived by the owner on May 22, 2025. It is now read-only.
RPEDs now work on APCs #13384
Merged
RPEDs now work on APCs #13384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Code looks fine, is this locally tested? This could also be made into a component 👀 |
Contributor
Author
|
@ToasterBiome yes, locally tested. If I hadn't locally tested it, |
Contributor
|
what if you put a fully charged bluespace cell in a brped and use it on an apc? will it be the original cell's charge or the bluespace cell's charge? |
Contributor
Author
|
@bruhlookatthisdood bluespace cell's charge. |
Contributor
thank you |
Yogbot-13
added a commit
that referenced
this pull request
Mar 7, 2022
Yogbot-13
added a commit
that referenced
this pull request
Mar 8, 2022
Yogbot-13
added a commit
that referenced
this pull request
Mar 10, 2022
Yogbot-13
added a commit
that referenced
this pull request
Mar 10, 2022
Yogbot-13
added a commit
that referenced
this pull request
Mar 10, 2022
JamieD1
approved these changes
Mar 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
RPEDs can now replace cells in APCs. Hopefully, science/engineering will actually upgrade APCs now.
The new cell is recharged by the old cell, so you can't use this to sabotage stuff by putting an empty bluespace cell in an BRPED and going ham.
Changelog
🆑 Lucy
rcsadd: RPEDs are now capable of changing the power cells in APCs now!
/:cl: