Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@NovaZure
Copy link
Contributor

@NovaZure NovaZure commented Mar 25, 2022

Document the changes in your pull request

Before this PR, replacing a borg's headlamp by placing a new bulb in would simply set the lamp's cooldown value to 0. This means that if the bulb was smashed, for example by a shadowling's light eater attack, replacing the bulb would not actually make the lamp functional again. This PR sets lamp_functional to True on top of reducing the cooldown to 0, which should actually fix the headlamp upon replacing the bulb.

Fixes #13504

Tested locally, works

Wiki Documentation

The replacement of a borg's lamp doesn't seem to be documented on the wiki, at least in the guide to robotics. It is possible to replace a borg's bulb by simply opening its cover and placing a new bulb inside just as if you were placing a new cell in a borg.

Changelog

🆑 NovaAzure
bugfix: Placing a new bulb into a borg fixes their headlamp
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Mar 25, 2022
Replacing a borg's bulb actually makes its lamp functional
@ToasterBiome
Copy link
Contributor

Does charging set the lamps cooldown to 0? if so, then this should regenerate the lamp too.

@NovaZure
Copy link
Contributor Author

NovaZure commented Mar 25, 2022

I cannot find anything in rechargestation.dm or robot.dm about changing a borg's lamp_cooldown or regenerating a headlamp. The problem that this PR fixes is that lamp_functional could be set to False, but there is nowhere in the code where lamp_functional could ever be set back to True. In the linked issue, sitting in the recharge station for copious amounts of time was also attempted with no success.

E: Looking further into this, I can't find any instances of lamp_cooldown being changed after initialization, and smash_headlamp is only ever called by shadowling/shadowperson abilities

@ToasterBiome ToasterBiome merged commit d440b7d into yogstation13:master Mar 26, 2022
Yogbot-13 added a commit that referenced this pull request Mar 26, 2022
@NovaZure NovaZure deleted the fix-lamp-repair branch March 27, 2022 02:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shadowling attack permanently breaks borg headlamp

3 participants