This repository was archived by the owner on May 22, 2025. It is now read-only.
Voice of God now works with accents, plus other say()-code bugfixes #13607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogbot-13
added
Fix
Member
|
god has no accent |
It's actually kinda complicated at this point, what the particular order of things should be within the say() verb. Before this change, vocal cords -- any vocal cords, even normal ones, could bypass: - Space making your voice not go as far - Items in your inventory that do things when you talk - Dying when you say something when very crit So this fixes that. Beyond that, this commit also ensures that succumbing from your final whisper happens consistently, regardless of how you speak, and that on_mob_say() is consistently called for inventory items.
Altoids1
force-pushed
the
voice-feminization-training
branch
from
024880b to
4a68703
Compare
JamieD1
approved these changes
Apr 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
say()code is getting kinda complicated. The original goal of this PR was to fixes #13414 (which it does), but as I was looking into it I found a bunch of other.. weird edge-cases and odd conditions happening within/mob/living/say()that I just kinda had to fix.Before this change, vocal cords -- any vocal cords, even normal ones, could bypass:
So this fixes that. Beyond that, this PR also ensures that succumbing from your final whisper happens consistently, regardless of how you speak, and that
on_mob_say()is consistently called for inventory items whenever you succeed at speaking.Wiki Documentation
Voice of God no longer always has a range of 8; it now has the range of any normal speech.
Changelog
🆑 Altoids
tweak: Voice of God, when used with the colossal vocal cords, now does not always have of a range of 8. Instead, it has same range as the typical speech of the user.
bugfix: Fixed hard accents making it impossible to use the Voice of God.
bugfix: Fixed vocal cords (including divine ones) bypassing the fact that it is hard to speak loudly in space.
bugfix: Fixed some edge-cases that allowed you to speak your last words when in full crit, without dying.
bugfix: Fixed objects that listen to your speech not picking it up in some circumstances.
/:cl: