This repository was archived by the owner on May 22, 2025. It is now read-only.
Cleaning up/fixing a lot of bad "send to world" code #14134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of "to_chat(world" use send_to_playing_players instead of SEND_SOUND to everyone that exists use sound_to_playing_players and use debug_world instead of random "to_chat(world" in the case that something goes wrong...
Bibby0110
suggested changes
May 16, 2022
Contributor
|
will this change people off the Z level getting station announcments? |
Contributor
Author
No |
JamieD1
approved these changes
May 21, 2022
Yogbot-13
added a commit
that referenced
this pull request
May 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Well this started out as a simple bugfix and I realized this was all over the damn place.
A lot of places used
to_chat(worldwhich sends a message to ALL CONNECTED PLAYERS including ones in the lobby. This has been substituted with the propersend_to_playing_players.Other places would SEND_SOUND to all players, and this was changed to the proper
sound_to_playing_players.Along the way I found some debug messages that were left in
to_chat(worldso in the off chance that something went wrong and they actually PLAYED, all players would getlover != Brutusoruh oh, stinky!!in their chat. Very cool.Some places were intentionally left out, particularly the Blob and Malf victory messages. As this ends the round instantly, and Jamie says not to touch it, it seems reasonable to me to keep it there and let lobby players know what happened. Until a maintainer says that shitting up the lobby chat is a bad idea, of course.
to_chat(world, "<B>[real_name] consumed the station in an unstoppable tide!</B>")to_chat(world, "<B>The AI cleansed the station of life with the doomsday device!</B>")There's a lot of other debug stuff in here but it seems pretty technical like savefile stuff so I'm not going to touch it until someone says to.
Closes #14133
Changelog
🆑
bugfix: Fixed darkspawn force divulge being shown to lobby players
bugfix: Fixed darkspawn sacrament noise being heard by lobby players
bugfix: Fixed shadowling ascendant death being shown to lobby players
bugfix: Fixed shadowling ascend message being shown to lobby players
bugfix: Fixed shadowling ascend noise being heard by lobby players
bugfix: Fixed a particular cult god fight being shown to lobby players
bugfix: Fixed Gamma & Epsilon alerts being heard by lobby players
bugfix: Fixed Epsilon alert giving lobby players a bad feeling
/:cl: