This repository was archived by the owner on May 22, 2025. It is now read-only.
Revert "Fleeing the station is now Crew Minor Victory instead of Major" #14685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bef12c6.
Bibby0110
approved these changes
Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12581
In theory - Crew kills the nukies, crew gets major,
In practice - Crew kills the nukies, the round ends immediately, and because the logic only counts a major when the station has been evacuated, it's counted as a minor.
Now while I guess I could omit the station evacuated check, I geninuely do not know what that might break (nor do I know how to test the end conditions). And on the principle of the orignal PR attempting to fix something that wasn't broken (in my opnion), I'd rather just revert the whole thing instead.
Changelog
🆑
tweak: Escaping with the disk on nuclear emergency is now a crew major again, instead of a minor
/:cl: