Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@VaelophisNyx
Copy link
Contributor

@VaelophisNyx VaelophisNyx commented Jul 13, 2022

BASS PRO SHOP SPACE STATION

Document the changes in your pull request

Adds a seed and nutrivendor to the garden, moves most of the machines around, axes all but one table and all the contents of all tables, puts 2 sets of gardening tools into a crate (bucket, spade, cultivator).
Adds water and a fishing vendor to the garden.

landmarks, pipes, and wires hidden for clarity:
ss (2022-07-12 at 07 57 34)

all shown:
ss (2022-07-12 at 07 58 46)

Wiki Documentation

Garden page will require updating to reflect these changes.
the seed vendor is a new type that doesn't have anything but what was originally in the garden, and the nutrivendor is varedited to remove the spare botany tools from it, except the plant analyzers and bags.

Changelog

🆑
rscadd: adds fishing to the box station Garden
rscadd: adds weaker MegaSeed Vendor that only has garden-approved seeds
tweak: massive overhaul for the box station Garden
/:cl:

@VaelophisNyx VaelophisNyx requested a review from a team as a code owner July 13, 2022 01:04
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Jul 13, 2022
@VaelophisNyx
Copy link
Contributor Author

topics to discuss:

  • Are there too many tools, should it be taken back down to 2 pairs
  • should I remove the ""dangerous"" seeds from the normal vendor stock and make it only what the tables had originally
  • does there need to be botany gloves in the garden crate, which exist entirely to stop nettles from pricking you

also less tools I guess.
@VaelophisNyx
Copy link
Contributor Author

went ahead and reduced the # of tools to 2 sets and took out corn and sugarcane seeds so you cant make easy bombs and get bamboo for spears/punji sticks easy without bugging botany.

@GraveHat
Copy link
Contributor

Consider cutting the variety of seeds and the amount of equipment back to old garden levels. If this goes through then the garden would be a bit too comparable to botany instead of being inferior even if they had to pay for seeds with their nonexistent paychecks because they could always just hack the vendor to spit out its contents instead of asking botany itself or cargo to get more seed variety.

@VaelophisNyx
Copy link
Contributor Author

I think that comes down to an admin/security issue of just
"why is the assistant allowed to hack the vendor unquestioned"

@GraveHat
Copy link
Contributor

GraveHat commented Jul 13, 2022

I think that comes down to an admin/security issue of just "why is the assistant allowed to hack the vendor unquestioned"

This goes for everyone as literally, no one enforces that hacking vending machines are illegal. It doesn't matter if it's technically illegal if the wider community doesn't see it as illegal, even if it is valid when it does get enforced.

@VaelophisNyx VaelophisNyx changed the title (Boxstation) Total garden overhaul featuring FISHING [Boxstation] Total garden overhaul featuring FISHING Jul 13, 2022
@VaelophisNyx VaelophisNyx changed the title [Boxstation] Total garden overhaul featuring FISHING [Box] Total garden overhaul featuring FISHING Jul 13, 2022
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a good one: How about you make a vendor that shares the sprite with the normal seed vendor but make it dispense the seeds of the things that used to be in the garden?

It doesn't increase the power of garden, plus it can be reused in other maps.

@ToasterBiome ToasterBiome added the Awaiting - Action - Author This PR is awaiting an action from the author label Jul 13, 2022
@VaelophisNyx
Copy link
Contributor Author

I mean couldn't that just be done via var-edits?

also makes the garden actually use it. Probably got the var edited nutrivendor right this time?
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Right window does not have plating under it please fix

also deletes the crate and scoots the tools over to that table
@VaelophisNyx
Copy link
Contributor Author

Corrected that, another window with the same issue, and moved the tools to the table, deleting the crate.

Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@VaelophisNyx
Copy link
Contributor Author

decided to fix this one now because it was small

@ToasterBiome ToasterBiome merged commit 08c782e into yogstation13:master Jul 17, 2022
Yogbot-13 added a commit that referenced this pull request Jul 17, 2022
@VaelophisNyx VaelophisNyx deleted the gardenfishing branch July 31, 2022 01:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Awaiting - Action - Author This PR is awaiting an action from the author Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants