Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@adamsong
Copy link
Contributor

@adamsong adamsong commented Aug 7, 2022

Document the changes in your pull request

Uses the forums to manage permissions instead of the database. Needs a small update to the endpoint to get rank names.

Still working on testing, will need much test merging to make sure is not broken.

Todo:

  • Grab rank from API endpoint (not implemented on endpoint)
  • Grab if admin should be grabbed from endpoint (not implemented on endpoint)
  • Re-implement DB backend as option
  • Protect funny lists

Changelog

🆑
tweak: Moved from db to forums as admin permissions backend.
/:cl:

@adamsong adamsong added the DO NOT MERGE Should not be merged without express approval from a Head Dev label Aug 7, 2022
@adamsong adamsong requested a review from a team as a code owner August 7, 2022 00:13
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Tweak This PR contains changes to the game. labels Aug 7, 2022
@adamsong adamsong added the Test Merge - Requested This PR is waiting for a test merge to be scheduled label Aug 7, 2022
@github-actions github-actions bot added Admin This PR affects administrators Config Config files need to be changed on the host for this to work labels Aug 7, 2022
Yogbot-13 added a commit that referenced this pull request Aug 7, 2022
@adamsong
Copy link
Contributor Author

adamsong commented Aug 9, 2022

Ah fuck, forgot about tgui linter

Yogbot-13 added a commit that referenced this pull request Aug 9, 2022
Yogbot-13 added a commit that referenced this pull request Aug 9, 2022
Yogbot-13 added a commit that referenced this pull request Aug 10, 2022
Yogbot-13 added a commit that referenced this pull request Aug 10, 2022
Yogbot-13 added a commit that referenced this pull request Aug 12, 2022
Yogbot-13 added a commit that referenced this pull request Aug 12, 2022
Yogbot-13 added a commit that referenced this pull request Aug 12, 2022
@JamieD1
Copy link
Contributor

JamieD1 commented Aug 14, 2022

This ready @alexkar598 @adamsong

@adamsong
Copy link
Contributor Author

I'd like alexkar's approval first, and it will need modiifying admins.txt and admin_ranks.txt

@alexkar598
Copy link
Member

I looked at the bits I was concerned about ie external interactions with the forums

Yogbot-13 added a commit that referenced this pull request Aug 14, 2022
@adamsong adamsong added TESTMERGED This PR is currently live in a test merge. and removed DO NOT MERGE Should not be merged without express approval from a Head Dev labels Aug 16, 2022
@adamsong
Copy link
Contributor Author

Ready to be merged @JamieD1 Don't forget to update admins.txt and admin_ranks.txt when merged

Yogbot-13 added a commit that referenced this pull request Aug 20, 2022
Yogbot-13 added a commit that referenced this pull request Aug 20, 2022
Yogbot-13 added a commit that referenced this pull request Aug 22, 2022
@JamieD1 JamieD1 merged commit 44cd06e into master Aug 28, 2022
@JamieD1 JamieD1 deleted the forum-integration branch August 28, 2022 13:26
Yogbot-13 added a commit that referenced this pull request Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Admin This PR affects administrators Config Config files need to be changed on the host for this to work DME Edit This PR affects the yogstation.DME file Test Merge - Requested This PR is waiting for a test merge to be scheduled TESTMERGED This PR is currently live in a test merge. Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants