Adds a new wizard spell, Mimicry

[Lichton]

My first PR!

Hello, I'm Photoshoot, and I've taken up the frankly absurd task of making a complicated new ability for a common antagonist as my first EVER code in Byond. However, I've spent like 5 days testing the balance, getting opinions on it, and fixing bugs/testing. I hope this is a sufficiently interesting feature for you all to consider merging it (AFTER the big bug I can't figure out is fixed). My intent with posting it here is just to show you all the code so you can understand my issue clearly, and help me figure out how to solve

The new spell.

Mimicry is a 1 spell point cost wizard spell in the Assistance category. When cast, it disguises the user as a random crewmember on the station. This completely alters your appearance and voice, but examination can still reveal you. However, this does not hide in hand items, so holding a staff or a gun will reveal you as a threat. It lasts for 15 seconds, with every level (Maximum upgrades is 2) giving it an extra 3 seconds.

After much bugfixing:

I believe I've idiot-proofed this spell as much as I can, all that's needed it to check that it functions normally for you guys off my computer.
🆑
rscadd: Added new wizard spell, Mimicry
imageadd: Added icon for Mimicry spell
/:cl:

[VaelophisNyx]

psst, put the icon here in the PR

[ynot01]

When the disguise is cast, it relies on you being a normal humanoid species, and prevents you from using the spell while you are not. HOWEVER, if you transform into anything other then a carbon during the spell (Shapechange spell included) your sprite can't be undisguised properly. I'm honestly not sure how I can fix this, but it'd have to be inside of revert_cast because that triggers whenever you become a carbon. Or, maybe doing it when your shape changes.

My advice would be to create TRAIT_NOWABBAJACK in code/__DEFINES/traits.dm and then apply that on cloak via ADD_TRAIT(L, TRAIT_NOWABBAJACK, MAGIC_TRAIT) where L is the mob, then removing it on decloak via REMOVE_TRAIT(L, TRAIT_NOWABBAJACK, MAGIC_TRAIT).

Then check for TRAIT_NOWABBAJACK via HAS_TRAIT(M, TRAIT_NOWABBAJACK) in code\modules\projectiles\projectile\magic.dm on /proc/wabbajack(mob/living/M, randomize).

[tattax]

Suggested change

	/obj/effect/proc_holder/spell/disguise
	name = "Mimicry"
	desc = "Why fight your foes when you can simply outwit them? Disguises the caster as a random crewmember."
	invocation = "CONJR DIS GUISE"
	invocation_type = "whisper"
	school = "transmutation"
	charge_max = 30 SECONDS
	level_max = 2
	cooldown_min = 25 SECONDS
	clothes_req = FALSE
	var/is_disguised = FALSE //Tells us if a disguise is currently up.
	action_icon = 'icons/mob/actions/actions_spells.dmi'
	action_icon_state = "disguise"
	/obj/effect/proc_holder/spell/disguise/can_cast(mob/user = usr)
	if(!ishuman(user))
	to_chat(user, span_danger("You cannot disguise as a non-humanoid!")) //The mob is not a human, so they can't disguise.
	//We need to undo the cloak after non-humanoid disguises because when the wizard becomes a non human during the spell, it will mess up their sprite. But since they are non human, we can't actually undo the spell. This leaves our recloaking bugged as hell, and breaks a lot of stuff.
	return FALSE
	return TRUE
	/obj/effect/proc_holder/spell/disguise/choose_targets(mob/user = usr)
	perform(user=user)
	/obj/effect/proc_holder/spell/disguise/cast(list/targets, mob/user = usr)
	var/mob/living/carbon/human/C = user //Turns the user into a carbon, we'll need this later.
	var/list/potentials = list()
	for(var/mob/living/carbon/human/H in GLOB.carbon_list) //Checks all the humanoid mobs.
	if(H.job) //Checks if they're crew.
	potentials += H //Adds the crewmember to the list.
	if(potentials.len == 0)
	to_chat(C, span_notice("There's nobody to disguise as!"))
	revert_cast(user)
	return
	var/mob/living/carbon/human/target = pick(potentials) //Picks a random subject from the viable targets.
	cloak(C, target)
	/obj/effect/proc_holder/spell/disguise/proc/cloak(var/mob/living/carbon/human/C, var/mob/living/carbon/human/target) //Code shortcut to enable the disguise.
	if(is_disguised)
	message_admins("[ADMIN_LOOKUPFLW(C)] just tried to disguise while disguised! That shouldn't happen!")
	return
	C.name_override = target.name
	C.SetSpecialVoice(target.name)
	new /obj/effect/temp_visual/dir_setting/ninja/cloak(get_turf(C), C.dir) //Disguise animation.
	C.icon = target.icon
	C.icon_state = target.icon_state
	C.cut_overlays()
	C.add_overlay(target.get_overlays_copy(list(HANDS_LAYER)))
	C.update_inv_hands()
	log_game("[C.name] has disguised as [target.name]!")
	is_disguised = TRUE
	addtimer(CALLBACK(src, .proc/undocloak, C), (15 SECONDS + (spell_level * 3 SECONDS)))
	return
	/obj/effect/proc_holder/spell/disguise/proc/undocloak(var/mob/living/carbon/human/C) //Code shortcut to disable the disguise.
	if(!is_disguised)
	log_game("[C.name] just undid their disguise while not disguised, shouldn't cause harm but it's weird.")
	return
	new /obj/effect/temp_visual/dir_setting/ninja(get_turf(C), C.dir) //Makes an animation for disguising.
	C.name_override = null
	C.UnsetSpecialVoice()
	C.cut_overlays()
	C.regenerate_icons()
	is_disguised = FALSE
	return
	/obj/effect/proc_holder/spell/disguise
	name = "Mimicry"
	desc = "Why fight your foes when you can simply outwit them? Disguises the caster as a random crewmember."
	invocation = "CONJR DIS GUISE"
	invocation_type = "whisper"
	school = "transmutation"
	charge_max = 30 SECONDS
	level_max = 2
	cooldown_min = 25 SECONDS
	clothes_req = FALSE
	var/is_disguised = FALSE //Tells us if a disguise is currently up.
	action_icon = 'icons/mob/actions/actions_spells.dmi'
	action_icon_state = "disguise"
	/obj/effect/proc_holder/spell/disguise/can_cast(mob/user = usr)
	if(!ishuman(user))
	to_chat(user, span_danger("You cannot disguise as a non-humanoid!")) //The mob is not a human, so they can't disguise.
	//We need to undo the cloak after non-humanoid disguises because when the wizard becomes a non human during the spell, it will mess up their sprite. But since they are non human, we can't actually undo the spell. This leaves our recloaking bugged as hell, and breaks a lot of stuff.
	return FALSE
	return TRUE
	/obj/effect/proc_holder/spell/disguise/choose_targets(mob/user = usr)
	perform(user=user)
	/obj/effect/proc_holder/spell/disguise/cast(list/targets, mob/living/carbon/C = usr) //Turns the user into a carbon, we'll need this later.
	var/list/potentials = list()
	for(var/mob/living/carbon/human/H in GLOB.carbon_list) //Checks all the humanoid mobs.
	if(H.job) //Checks if they're crew.
	potentials += H //Adds the crewmember to the list.
	if(!potentials.len)
	to_chat(C, span_notice("There's nobody to disguise as!"))
	revert_cast(user)
	return
	var/mob/living/carbon/human/target = pick(potentials) //Picks a random subject from the viable targets.
	cloak(C, target)
	/obj/effect/proc_holder/spell/disguise/proc/cloak(mob/living/L, mob/living/target) //Code shortcut to enable the disguise.
	if(is_disguised)
	message_admins("[ADMIN_LOOKUPFLW(C)] just tried to disguise while disguised! That shouldn't happen!")
	return
	new /obj/effect/temp_visual/dir_setting/ninja/cloak(get_turf(L), L.dir) //Disguise animation.
	if(ishuman(L))
	var/mob/living/carbon/human/H = L
	H.name_override = target.name
	H.SetSpecialVoice(target.name)
	H.icon = target.icon
	H.icon_state = target.icon_state
	H.update_inv_hands()
	L.cut_overlays()
	L.add_overlay(target.get_overlays_copy(list(HANDS_LAYER)))
	log_game("[L.name] has disguised as [target.name]!")
	is_disguised = TRUE
	addtimer(CALLBACK(src, .proc/undocloak, L), (15 SECONDS + (spell_level * 3 SECONDS)))
	/obj/effect/proc_holder/spell/disguise/proc/undocloak(mob/living/L) //Code shortcut to disable the disguise.
	if(!is_disguised)
	log_game("[L.name] just undid their disguise while not disguised, shouldn't cause harm but it's weird.")
	return
	new /obj/effect/temp_visual/dir_setting/ninja(get_turf(L), L.dir) //Makes an animation for disguising.
	if(ishuman(L))
	var/mob/living/carbon/human/H = L
	H.name_override = null
	H.UnsetSpecialVoice()
	L.cut_overlays()
	L.regenerate_icons()
	is_disguised = FALSE

[tattax]

problem probably is if you shapeshift it runtimes in the middle of the uncloak proc, see the dream deamon panel or the runtime checker in the admin tabs for these

[Lichton]

This wouldn't fix it, because if they were human during the undisguise it would just leave their name messed up.

[Lichton]

Rather, if they are NON human

[Lichton]

oh wait you have a genius idea, nevermind LOL

[Lichton]

psst, put the icon here in the PR

I actually did, extremely confused

When the disguise is cast, it relies on you being a normal humanoid species, and prevents you from using the spell while you are not. HOWEVER, if you transform into anything other then a carbon during the spell (Shapechange spell included) your sprite can't be undisguised properly. I'm honestly not sure how I can fix this, but it'd have to be inside of revert_cast because that triggers whenever you become a carbon. Or, maybe doing it when your shape changes.

My advice would be to create TRAIT_NOWABBAJACK in code/__DEFINES/traits.dm and then apply that on cloak via ADD_TRAIT(L, TRAIT_NOWABBAJACK, MAGIC_TRAIT) where L is the mob, then removing it on decloak via REMOVE_TRAIT(L, TRAIT_NOWABBAJACK, MAGIC_TRAIT).

Then check for TRAIT_NOWABBAJACK via HAS_TRAIT(M, TRAIT_NOWABBAJACK) in code\modules\projectiles\projectile\magic.dm on /proc/wabbajack(mob/living/M, randomize).

Luckily there is a notransform for living creatures.

[VaelophisNyx]

no no I mean put like, an exported GIF of it in the actual PR reason stuff, not just in the DMI file; so it's easier to see

[ghost]

Check bloodsuckers veil spell and try reusing it's code instead of doing such horrific things like user.icon = target.icon

[Lichton]

no no I mean put like, an exported GIF of it in the actual PR reason stuff, not just in the DMI file; so it's easier to see

No I mean I did put that in the PR, right under the spell icon area, for some reason it didn't show up.

Check bloodsuckers veil spell and try reusing it's code instead of doing such horrific things like user.icon = target.icon

Bloodsuckers veil literally just doesn't do the thing I want it to do? This is the exact same code as the abductor code, which is already in the game, and has the same effect. I really don't understand your complaint here.

[ghost]

Bloodsuckers veil literally just doesn't do the thing I want it to do? This is the exact same code as the abductor code, which is already in the game, and has the same effect. I really don't understand your complaint here.

I mean not the randomising part, i mean that it would be better to copy special apearance things rather then copying the icon

[cuackles]

Try to still put the sprite in the PR post so it's more easy to see, but being that this is your first pr and stuff i will let that slide being that it's only 1 sprite added, the icon is acceptable, so basically tldr keep trying to put the icon on the post but how it's your first pr it will still get the art approval, still try to fix it

[Lichton]

Try to still put the sprite in the PR post so it's more easy to see, but being that this is your first pr and stuff i will let that slide being that it's only 1 sprite added, the icon is acceptable, so basically tldr keep trying to put the icon on the post but how it's your first pr it will still get the art approval, still try to fix it

Ye I will, I put it in the original post but for some reason didn't come through, and I forgot to ever put it in later

[Lichton]

This is 100% ready by the way to merge