Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@VaelophisNyx
Copy link
Contributor

@VaelophisNyx VaelophisNyx commented Sep 19, 2022

Document the changes in your pull request

Partially reverts: #14495

Chem dispensers now have iron, and water, back in t1. This was a bit of an over-reaching nerf that was slapped on this.

t2 now nets chemists sugar and sulfuric acid, which were previously t1, along side fuel which has not been changed.

t3 unlocks only acetone, ammonia, and ash

t4 unlocks diethylamine, saltpetre, and now charcoal, and gold

emagging it now features uranium in addition to the previous set of chems

NEW REACTIONS

  • 3 Water (1 oxygen, 2 hydrogen, 380K) AND (Ice above 400K)
  • 3 Ice (2 Water, 1u Lye put at or below 200K)
  • 6 Stable Plasma (3 Plasma, 3 Hydrogen, 5 Ethanol as catalyst, 100K)
  • 4 Welding Fuel (1 Oil, 3 Sulfuric Acid, 180K)
  • 2 Sulfuric Acid (1 Sulfur Trioxide, 1 Water)
  • 4 Sulfur Trioxide (1 Sulfur, 3 Oxygen, 1u Hydrogen as a catalyst)
  • 3 Sugar (1 Carbon, 1 Oxygen, 1 Welding Fuel)

NEW REAGENT:

  • Sulfur Trioxide, a mostly useless precursor to Sulfuric Acid

cleaned up some 1/0s to be TRUE/FALSE instead

Wiki Documentation

Requires updates to the Guide To Chemistry's dropdown box for the reagent tiers, and addition of Sulfur Trioxide to the guide itself, along side the new reactions documented above.

Changelog

🆑 VaelophisNyx, @ToasterBiome, @Chubbygummibear, @redmoogle, MasterDrake
rscadd: Added Sulfur Trioxide + Reaction to make it
rscadd: Added new chemical reactions to produce water, welding fuel, stable plasma, ice, sugar, and Sulfuric Acid
tweak: Chem dispenser chems now unlocked at different tiers, and features gold and charcoal at t4, and uranium when emagged.
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Tweak This PR contains changes to the game. labels Sep 19, 2022
@VaelophisNyx VaelophisNyx marked this pull request as ready for review September 19, 2022 23:46
@Cartlord
Copy link
Contributor

why is this good for the game and why are your changes unatomic

@VaelophisNyx
Copy link
Contributor Author

VaelophisNyx commented Sep 21, 2022

why is this good for the game

Because currently chemistry is painful to do without any upgrades at all unlike just about any other sub-department, because it was nerfed a little TOO hard. This corrects this, letting chemists actually do their job for the first 20m instead of harassing science.

why are your changes unatomic

because the new reactions and reagent are there to support the changes :)

@VaelophisNyx
Copy link
Contributor Author

VaelophisNyx commented Sep 21, 2022

more important question, I have to ask, cart

why do you care? I dont recall you being a maintainer?

@redmoogle
Copy link
Contributor

why is this good for the game and why are your changes unatomic

regardless of if any reason was put on there why would it matter. If you think its a good PR nobody will mention it but if you think its a PR people will find random excuses to rag on it

@SomeguyManperson
Copy link
Contributor

why is this good for the game and why are your changes unatomic

regardless of if any reason was put on there why would it matter. If you think its a good PR nobody will mention it but if you think its a PR people will find random excuses to rag on it

I for one like knowing why people are making decisions that impact the game because otherwise it can end up feeling like they're throwing shit at the wall until it sticks

why are your changes unatomic

because the new reactions and reagent are there to support the changes :)

to be fair this could be pointed at the code refining 1/0 to true/false bit and most of the recipes being added don't have any impact on what chem can do i.e. ice/melting and stable plasma and etc, I can assume they were added during the development process but they seem to be more important for ghetto chemistry than actual chemistry in the current state of the pr

VaelophisNyx and others added 3 commits September 21, 2022 20:03
Co-authored-by: Theos <theubernyan@gmail.com>
Co-authored-by: Theos <theubernyan@gmail.com>
Co-authored-by: Theos <theubernyan@gmail.com>
@VaelophisNyx
Copy link
Contributor Author

so I cant reply to the radium question for ...some reason, but basically, it's used in Very Few recipes that you shouldn't really need done much at all. I do recognize that this makes it unobtainable outside of rare goo splotches though, if you never get upgrades, since it's a normally chemistry only reagent. This was just another part of trying to preserve some form of balance while making chemists lives at round-start a smidge easier

@SomeguyManperson
Copy link
Contributor

radium is still in tier 1 though it's just lower

@VaelophisNyx
Copy link
Contributor Author

Oh, right
god I need less open PRs

initially it was intended to be T4
T1'd again to preserve ordering
chem dispenser code is fucked

@ToasterBiome
Copy link
Contributor

i fuged it

@VaelophisNyx
Copy link
Contributor Author

all good g

@JamieD1 JamieD1 merged commit 134026e into yogstation13:master Oct 8, 2022
Yogbot-13 added a commit that referenced this pull request Oct 8, 2022
@VaelophisNyx VaelophisNyx deleted the chemistry-alterations branch October 29, 2022 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants