This repository was archived by the owner on May 22, 2025. It is now read-only.
Fixes Mining Point Duplication bug, issue #16617 #16827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please review, I am worried I used wrong list proc. |
Contributor
|
don't use [s] here. looks good though |
Contributor
|
you could put #16617 in the descripton so its linked |
Contributor
Contributor
Author
Thank you, that linked it! |
Contributor
|
Contributor
|
also few ways to link issues that will close them once ur pr is merged: fix, fixes, fixed, resolve, resolves, resolved, close, closes, closed |
Contributor
Author
Thank you for letting me know! This is the wrong PR for this issue, but I have linked this issue to my other PR you were thinking of (it's already merged though) |
Firewolf34
changed the title
JamieD1
approved these changes
Dec 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Resolves the issue with the gems. The gem array was not having the miner ID card removed from its keys upon redemption, resulting in cascading redemptions. I used list.Remove() proc and it seems to fix the issue. Also, it was removing at the wrong time; when it did manage to remove from the list, it caused the message to null-ref. Resolved.
Tested against latest master locally at 8a405ed
Cannot reproduce with these fixes. Additionally, list appears to have the id card removed properly now, even when 2 different mobs (distinct id cards) are used. I have not tested several gems at once per player, nor have I tested with many players or non-mobs.
Resolves #16617
Changelog
🆑
bugfix: Miners will not be overcompensated for gems anymore
/:cl: