Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Notamaniac
Copy link
Contributor

@Notamaniac Notamaniac commented Dec 14, 2022

Document the changes in your pull request

Fixes #17065
Fixes #17046 (dupe issue)

Spriting

New plort maintenance hatch sprite : credit cuackles orca

Wiki Documentation

None

Changelog

🆑
bugfix: Plort machine no longer turns invisible when screwdrivered
/:cl:

@Notamaniac Notamaniac requested a review from a team as a code owner December 14, 2022 18:48
@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Sprites This PR has spriting changes labels Dec 14, 2022
@Notamaniac
Copy link
Contributor Author

no i did not link the wrong issue shut up

@cuackles
Copy link
Contributor

fun fact i gave manatee an icon to fix that issue 3 days ago , so this is legally not my fault B)

@cuackles
Copy link
Contributor

ok so viewing the sprite i really like the idea of the orange part being a cover from the circuits and it going up, issue i see is that at the most bottom it breaks the illusion of a cylinder , here specifically
image
, it also removes the bottom grey part wich i also see as an issue, thats the issues i see with the desing, maybe the ligthing could use some more work too as the pieces move, if you are willing to do that and do it ping me when its done to give it another review/aproval, that being said if you consider that to much hassle i can give you the one i did and gave to manatee for you to use it instead, that one looking like this
image
image

@Notamaniac
Copy link
Contributor Author

yeah it was just a quick five minute sprite, I'll just use yours

Copy link
Contributor

@MajManatee MajManatee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha oops

@cuackles
Copy link
Contributor

eyeyaysidnasjiond
here is the orca aproved version, please update the dmi so we can merge

@Bibby0110 Bibby0110 enabled auto-merge (squash) December 15, 2022 22:40
auto-merge was automatically disabled December 16, 2022 13:32

Head branch was pushed to by a user without write access

Copy link
Contributor

@KillerOrcaCora KillerOrcaCora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rip

@KillerOrcaCora KillerOrcaCora merged commit 2c55857 into yogstation13:master Dec 21, 2022
Yogbot-13 added a commit that referenced this pull request Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs Sprites This PR has spriting changes

Projects

None yet

6 participants