Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Notamaniac
Copy link
Contributor

@Notamaniac Notamaniac commented Dec 15, 2022

Document the changes in your pull request

Fixes #17081
Fixes #14996 (dupe issue)

Need to preface this, I have no idea what the state var is doing, only that it shouldn't be there, and that there are no other instances where this proc is specfically called using the state var. Was this meant to be something like an out parameter in c#? Why was it the first argument, especially when you can't overload procs like in c#? Was this code tested? I have zero idea to any of these questions, only that removing it doesn't seem to break anything.

Spriting

N/A

Wiki Documentation

N/A

Changelog

🆑
bugfix: Bag of holdings should now appear in your hands, on your back and... head.
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Dec 15, 2022
@Notamaniac
Copy link
Contributor Author

but turdis said no

@warface1234455
Copy link
Contributor

warface1234455 commented Dec 16, 2022

but turdis said no

[23:44:08] Runtime in _head.dm,38: Cannot read null.zone_selected
  proc name: throw impact (/obj/item/clothing/head/throw_impact)
  src: the white cap (/obj/item/clothing/head/yogs/whitecap)
  src.loc: space (209,114,2) (/turf/open/space/basic)
  call stack:
  the white cap (/obj/item/clothing/head/yogs/whitecap): throw impact(the toxins launcher bay door (/obj/machinery/door/poddoor), /datum/thrownthing (/datum/thrownthing))
  /datum/thrownthing (/datum/thrownthing): finalize(1, the toxins launcher bay door (/obj/machinery/door/poddoor))
  /datum/thrownthing (/datum/thrownthing): hit atom(the toxins launcher bay door (/obj/machinery/door/poddoor))
  the white cap (/obj/item/clothing/head/yogs/whitecap): Bump(the toxins launcher bay door (/obj/machinery/door/poddoor))
  the plating (208,114,2) (/turf/open/floor/plating): Enter(the white cap (/obj/item/clothing/head/yogs/whitecap), space (209,114,2) (/turf/open/space/basic))
  the white cap (/obj/item/clothing/head/yogs/whitecap): Move(the plating (208,114,2) (/turf/open/floor/plating), 8, 32)
  the white cap (/obj/item/clothing/head/yogs/whitecap): Move(the plating (208,114,2) (/turf/open/floor/plating), 8, 32)
  /datum/thrownthing (/datum/thrownthing): tick()
  Throwing (/datum/controller/subsystem/throwing): fire(0)
  Throwing (/datum/controller/subsystem/throwing): ignite(0)
  Master (/datum/controller/master): RunQueue()
  Master (/datum/controller/master): Loop()
  Master (/datum/controller/master): StartProcessing(0)

hmm seems like it doesn't do anything with this, try to recommit again for it to rebuild, turdis sometimes be funky

@warface1234455
Copy link
Contributor

also fix this aswell #14996

Copy link
Contributor

@warface1234455 warface1234455 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyways code looks fine, also checked out and tested this myself, no runtime so this is good for merge just recommit again so turdis can compile this properly, tudis is funky as hell

@Moltijoe Moltijoe merged commit 166aae4 into yogstation13:master Dec 18, 2022
Yogbot-13 added a commit that referenced this pull request Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bag of holding is invisible when worn Bags of Holding are invisible

4 participants