Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

TGUI Preferences Menu + total rewrite of the preferences backend #17381

Merged
JamieD1 merged 245 commits into from
Jan 28, 2023
Merged

TGUI Preferences Menu + total rewrite of the preferences backend #17381

JamieD1 merged 245 commits into from
Jan 28, 2023

Conversation

@ThatLing
Copy link
Contributor

@ThatLing ThatLing commented Jan 7, 2023 •
edited
Loading

Document the changes in your pull request

So this, is a big one and will break a lot of stuff.

Mainly ports tgstation/tgstation#61313, which a whole bunch of extra stuff because we are so outdated. Currently still heavily WIP, so no screenshots yet. If you want to know what it looks like, go to the original PR.

TODO:

  • Antag page
    • Update antags
  • Update species:
    • Lore & descriptions
    • Icons (e.g. mothpeople)
    • Traits
  • Fix randomization
  • Fix customization (always bald)
  • Fix selecting species (always human)
  • Port all client.prefs to new system
    • Port all yog prefs
  • Fix quirk icons
  • Movement keybinds are broken
  • Double check performance settings
  • Fix preferences saving
  • Add appearances for races (e.g IPC)
  • Update TGUI in CI
  • Bugs
    • Random name broken
    • Random species broken
    • Radio colors broken (command, common, etc)
    • Asay colors broken
    • Admin ticket href broke (auto name follow thingy)
    • Occupations screen BSOD
    • Ghost form changing turns you invis
    • Hair color still broken
    • Cannot add/remove quirks
    • Verify ghost settings being transferred over
    • Verify transferred chars having random stuff (e.g. jumpsuit and backpack)
    • No lizard horns or frills

Full list of ported PRs, credits to the original authors and to Thatling, JamieD12 and Bibby for Porting:

Changelog

🆑 Mothblocks & various contributors to /tg/ Ported by ThatLing and JamieD12
rscadd: The preferences menu has been completely rewritten in tgui.
tweak: The "Stop Sounds" verb has been moved to OOC.
rscadd: Donators can now select a plushie.
/:cl:

ThatLing and others added 2 commits January 6, 2023 22:29
@ThatLing
TGUI Preferences Menu + total rewrite of the preferences backend (#17368
588db2e 
)

* It compiles

* It opens

* Sync 1

* Add asset caching

* Sync 2

* It opens without dev now

* Update a few packages

* Sync 3

* Sync 4

keybind fix

* start of dehardcoded species

* Small fixes

* Add more individual preferences

* ASS sync
@Yogbot-13
Automatic changelog generation #17368 [ci skip]
c98134e
@ThatLing ThatLing requested review from a team as code owners January 7, 2023 10:26
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Tweak This PR contains changes to the game. labels Jan 7, 2023
@ThatLing ThatLing marked this pull request as draft January 7, 2023 10:26
@ThatLing ThatLing added DO NOT MERGE Should not be merged without express approval from a Head Dev WORK IN PROGRESS This PR will take a while before its complete, but is actively being worked on. Refactor Makes old code less shit labels Jan 7, 2023
ThatLing
ThatLing commented Jan 7, 2023
View reviewed changes
Copy link
Contributor Author

@ThatLing ThatLing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from previous PR, thanks Moltijoe

yogstation/code/modules/mob/living/carbon/human/species_types/preternis/preternis.dm
/datum/species/preternis/create_pref_unique_perks()
var/list/to_add = list()

// TODO
Copy link
Contributor Author

@ThatLing ThatLing Jan 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably something about
self surgery and self repair from being metal
Emp immunity
Eyes functioning to give night vision
Crippling weakness to water
Can't wear shoes, but have innate magboot abilities
purges all chems after a short time
reduced oxygen needed to breathe

Ideally try to roll some of these together to reduce bloat

@MajManatee
Copy link
Contributor

MajManatee commented Jan 7, 2023

i wonder if this is gonna break anything essential again...

JamieD1 and others added 17 commits January 7, 2023 18:15
JamieD1 pushed a commit that referenced this pull request Jan 26, 2023
@Yogbot-13
TGS Test merge #17381
f52b3ef
@ThatLing ThatLing mentioned this pull request Jan 26, 2023
Merged
@MajManatee
Copy link
Contributor

MajManatee commented Jan 26, 2023

Alternate human name doesnt work

JamieD1 pushed a commit that referenced this pull request Jan 26, 2023
@Yogbot-13
TGS Test merge #17381
4dba9eb
JamieD1 pushed a commit that referenced this pull request Jan 27, 2023
@Yogbot-13
TGS Test merge #17381
ab53024
@Majkl-J Majkl-J mentioned this pull request Jan 27, 2023
Closed
JamieD1 pushed a commit that referenced this pull request Jan 27, 2023
@Yogbot-13
TGS Test merge #17381
e151ab4
JamieD1 pushed a commit that referenced this pull request Jan 28, 2023
@Yogbot-13
TGS Test merge #17381
e7fe8a5
JamieD1 pushed a commit that referenced this pull request Jan 28, 2023
@Yogbot-13
TGS Test merge #17381
5391a76
@JamieD1 JamieD1 merged commit a6d7e3f into master Jan 28, 2023
@JamieD1 JamieD1 deleted the preferences branch January 28, 2023 15:26
Yogbot-13 added a commit that referenced this pull request Jan 28, 2023
@Yogbot-13
Automatic changelog generation #17381 [ci skip]
792d29c
@Oblisk234 Oblisk234 mentioned this pull request Nov 7, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JamieD1 JamieD1 JamieD1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Config Config files need to be changed on the host for this to work Feature This adds new content to the game Icon Change This PR changes icons IMPORTANT Important stuff. On hold - HD Should not be merged without HD Approval Refactor Makes old code less shit TESTMERGED This PR is currently live in a test merge. Tweak This PR contains changes to the game.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ThatLing @MajManatee @JamieD1 @Yogbot-13 @Bibby0110 @adamsong