This repository was archived by the owner on May 22, 2025. It is now read-only.
TG DNA update attempt #3: post-TGUI preferences edition #18197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ho * pod nerfed by a pod main * sugone * yea * yer * lotsa stuff * tgui is pain * i don't know * maybe? * god kill me * tailed * wait no i fixed it wrong, this should be better * SCOPE CREEP BABEEEEEEEEEE * sins * mother of all omlettes jack * is it over? * ethereal colors because idk * i think that's it until we find out what else i broke cl ass clean up debug messages last one probably * Revert "i think that's it until we find out what else i broke" This reverts commit 574b0e8. * last time with gusto * hhh * ho * pod nerfed by a pod main * yer * fix * Revert "fix" This reverts commit 979eddb. * Delete plantpeople.dm * Revert "Merge branch 'dna-blocks-but-like-good' of https://github.com/Chubbygummibear/Yogstation-TG into dna-blocks-but-like-good" This reverts commit 1756ff2, reversing changes made to 05f88be. * this shouldn't be in here * missed that * so many little things * please for the love of god work
Contributor
|
The manmade horrors beyond our comprehension |
Moltijoe
reviewed
Apr 16, 2023
Moltijoe
approved these changes
May 1, 2023
Contributor
Moltijoe
left a comment
Moltijoe
left a comment
There was a problem hiding this comment.
i can't find anything wrong, most of this is just rearranging code and changing hexvalues
the new parts don't look broken, so hopefully there isn't a secret bug mixed in
perhaps overly hopeful considering this game
Moltijoe
added
Awaiting - Action - HD
Contributor
|
would be awesome to see this become real |
Contributor
|
Damn this is stale |
Yogbot-13
added
Feature
Contributor
|
I'll reopen this if the merge conflicts get fixed |
* ho * pod nerfed by a pod main * sugone * yea * yer * lotsa stuff * tgui is pain * i don't know * maybe? * god kill me * tailed * wait no i fixed it wrong, this should be better * SCOPE CREEP BABEEEEEEEEEE * sins * mother of all omlettes jack * is it over? * ethereal colors because idk * i think that's it until we find out what else i broke cl ass clean up debug messages last one probably * Revert "i think that's it until we find out what else i broke" This reverts commit 574b0e8. * last time with gusto * hhh * ho * pod nerfed by a pod main * yer * fix * Revert "fix" This reverts commit 979eddb. * Delete plantpeople.dm * Revert "Merge branch 'dna-blocks-but-like-good' of https://github.com/Chubbygummibear/Yogstation-TG into dna-blocks-but-like-good" This reverts commit 1756ff2, reversing changes made to 05f88be. * this shouldn't be in here * missed that * so many little things * please for the love of god work
This reverts commit b18dc91.
Contributor
Author
|
merge conflicts resolved. again. for the morbillionth time. if i see merge conflicts again i would rather delete this entire branch than maintain it again |
Yogbot-13
added a commit
that referenced
this pull request
Jul 31, 2023
Yogbot-13
added a commit
that referenced
this pull request
Aug 1, 2023
Yogbot-13
added a commit
that referenced
this pull request
Aug 1, 2023
Yogbot-13
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously #14861
Round 3?
yeah i'm like
90%70% certain i ironed out the preference savefile quirks and it won't break your characters into grayscale monstrositiesYour prefs will auto save with the full hexcode colors while retaining your color choices next time you launch and this is active
Document the changes in your pull request
More specifically ports
What does this actually do?
well if i did everything perfectly right, 90% of players won't notice anything changed. xeno traits such as lizard frills, pod hair, and moth wings are all stored in a separate chunk of dna that everyone has, meaning they can be edited through genetics as well as dna injectors working on the same species instead of only working for and on humans.
Did you spend a
weekmonthyear porting tg's dna code just to add stuff to genetics?yeah
Wiki Documentation
I'm unsure how much the wiki covers about dna, but maybe a blurb about DNA storing mutant features now, and genetics being able to alter these
Changelog
🆑 @Y0SH1M4S73R, @Ghommie, Chubbygummibear
rscadd: The DNA console can now edit the nonhuman features of its occupants, as well as allowing injectors to apply those features. Look for the "Features" tab in the DNA console.
rscadd: everyone has a whole new dna block called unique_features that holds things like mutant color and alien bits settings. unique features can be altered and copied onto other people through genetics. this only works on people of the same species
wip: this is probably going to need a lot of ongoing work
tweak: hexcolors are handled differently
bugfix: glowy color works
bugfix: extendo arm color matches your mcolor
tweak: removes color_legacy prefs and changes sanitize_hexcolor()'s default to 6 characters
experimental: Whole lotta DNA and color code reworking
/:cl: