[Bounty] Adds the CVS recipient injector

[BurgerLUA]

Link to bounty: https://forums.yogstation.net/threads/90-4-4-give-traitor-virologist-sentient-disease-kit.24327/

Notice

WIP and untested. Don't give me money yet until I know it works and the payee is satisfied.

TODO list

• Test it.
• Make sprites for it.
• Balance it.

Document the changes in your pull request

Adds the CVS recipient injector, a 20TC Hijack only Virologist traitor item that silently injects someone with a disease and makes the mentioned disease sentient. Has 3 uses.

Why is this good for the game.

Icons

Changelog

🆑
rscadd: Adds the CVS recipient injector, a 20TC Hijack only Virologist traitor item that silently injects someone with a disease and makes the mentioned disease sentient. Has 3 uses.
/:cl:

[tattax]

could you link the bounty pretty please

[BurgerLUA]

could you link the bounty pretty please

Edited so that the bounty is linked in the OP.

[Rdrazga]

I struggle to understand the bounty this is for and why it would be better then just giving the virologist a traitor item that lets them break the normal 6 symptom limit without having to rely on a ghost who likely never played virology to not just instantly ruin the virus

[Rdrazga]

Or how insanely unbalanced this would be if said ghost did know virology due to having access to symptoms sentient viruses normally don’t get for balance reasons

[ehj236]

Or how insanely unbalanced this would be if said ghost did know virology due to having access to symptoms sentient viruses normally don’t get for balance reasons

I could reverse it instead but I would like to expand upon Sentient disease so that future devs may take a look at it in the future as something that can eventually be fixed, besides viros with access to infinite symptoms by themselves would be literally gamebreaking in every regard, take note of APN(autophagocytosis necrosis) or ARDS(Acute respiratory distress syndrome) even Tumors while by themselves in 6 symptom restrictions. I would rather it be a two person job than someone who becomes a actual god with access to one of the most powerful systems in the entire game apart that rivals both xenobiology, nanites, robotics and even trumps the great works of genetics.

[MajManatee]

Please don't have a sprite that's unused. Especially if its just to show what it looks like

[BurgerLUA]

Please don't have a sprite that's unused. Especially if its just to show what it looks like

There are no unused sprites. The sprite (what it looks like) is not actually inside the .dmi file.

[BurgerLUA]

I have no way to test this since I have no friend, but it should work.

It compiles, so it works.

[cuackles]

aproved

[BurgerLUA]

Okay so requesting a testmerge on this since I have no way to test it. Here are case scenarios of what would happen during a round with this in terms of shit breaking.

Average Case Scenario
The virus that the virologist made doesn't get properly merged with the sentient virus and you just have a sentient viruses injector with the sentient disease starting cough.

Best Case Scenario
It actually works flawlessly.

Worst Case Scenario
Runtime errors occur every time the sentient disease infects someone or tries to open a menu because it has symptoms that a sentient disease never actually is supposed to get.

[ynot01]

Runtime

[2023-07-23 23:50:34.801] [00:48:47] runtime error: Cannot modify null.appearance.
 - proc name: add infection (/mob/camera/disease/proc/add_infection)
 -   source file: disease_mob.dm,230
 -   usr: Alexander Crawford (/mob/living/carbon/human)
 -   src: Sentient Disease (/mob/camera/disease)
 -   usr.loc: the floor (86,151,2) (/turf/open/floor/plasteel)
 -   src.loc: the floor (75,155,2) (/turf/open/floor/plasteel)
 -   call stack:
 - Sentient Disease (/mob/camera/disease): add infection(Sentient Virus (/datum/disease/advance/sentient_disease))
 - Sentient Virus (/datum/disease/advance/sentient_disease): after add()
 - Sentient Virus (/datum/disease/advance/sentient_disease): infect(the monkey (796) (/mob/living/carbon/monkey), 0)
 - Sentient Virus (/datum/disease/advance/sentient_disease): infect(the monkey (796) (/mob/living/carbon/monkey), 0)
 - Sentient Virus (/datum/disease/advance/sentient_disease): try infect(the monkey (796) (/mob/living/carbon/monkey), 0)
 - the monkey (796) (/mob/living/carbon/monkey): ForceContractDisease(Sentient Virus (/datum/disease/advance/sentient_disease), 0, 1)
 - Sentient Disease (/mob/camera/disease): force infect(the monkey (796) (/mob/living/carbon/monkey))
 - the CVS recipient injector (/obj/item/sentient_disease_injector): create sentient virus(the monkey (796) (/mob/living/carbon/monkey), Alexander Crawford (/mob/living/carbon/human))
 - world: ImmediateInvokeAsync(the CVS recipient injector (/obj/item/sentient_disease_injector), /obj/item/sentient_disease_inj... (/obj/item/sentient_disease_injector/proc/create_sentient_virus), the monkey (796) (/mob/living/carbon/monkey), Alexander Crawford (/mob/living/carbon/human))

[ynot01]

does this dangling ] need to be here?

[ynot01]

Allow the sentient disease to pick a name via INVOKE_ASYNC(virus, TYPE_PROC_REF(/mob/camera/disease, pick_name))

[Bibby0110]

Very stale.