Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Partially Revert "Metallic hydrogen production now requires EFFORT (#15333)" and few adjustments #19538

Merged
ToasterBiome merged 9 commits into from
Jul 26, 2023
Merged

Partially Revert "Metallic hydrogen production now requires EFFORT (#15333)" and few adjustments #19538

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5eb8778
Partially Revert "Metallic hydrogen production now requires EFFORT (#…
warface1234455 Jul 5, 2023
3398dc5
just change the number instead of adding of math
warface1234455 Jul 5, 2023
ffe73ed
th
warface1234455 Jul 5, 2023
685b874
alr
warface1234455 Jul 5, 2023
9157a43
c
warface1234455 Jul 6, 2023
b41b3d4
do
warface1234455 Jul 6, 2023
47bdcd6
more bz consumption
warface1234455 Jul 6, 2023
83fd3b3
log
warface1234455 Jul 7, 2023
97fc615
d
warface1234455 Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions code/modules/atmospherics/gasmixtures/reactions.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ nobliumformation = 1001

/datum/gas_reaction/metalhydrogen/init_reqs()
min_requirements = list(
/datum/gas/hydrogen = 1000,
/datum/gas/hydrogen = 300, //same crystallizer recipe
/datum/gas/bz = 50,
"TEMP" = METAL_HYDROGEN_MINIMUM_HEAT
)
Expand All @@ -688,20 +688,19 @@ nobliumformation = 1001
if(!isturf(holder))
return NO_REACTION
var/turf/open/location = holder
///More heat means higher chance to react but less efficiency, i.e. higher speed lower yield
var/increase_factor = min(log(10 , (temperature / METAL_HYDROGEN_MINIMUM_HEAT)), 5) //e7-e12 range
///the more heat you use the higher is this factor
var/increase_factor = min(log(10 , (temperature / METAL_HYDROGEN_MINIMUM_HEAT)), 5) //e7-e12 range
///the more moles you use and the higher the heat, the higher is the efficiency
var/heat_efficency = air.get_moles(/datum/gas/hydrogen)* 0.01 * increase_factor //This variable name is dumb but I can't be assed to change it
var/heat_efficency = air.get_moles(/datum/gas/hydrogen)* 0.01 * increase_factor //This variable name is dumb but I can't be assed to change it
var/pressure = air.return_pressure()
var/energy_used = heat_efficency * METAL_HYDROGEN_FORMATION_ENERGY

if(pressure >= METAL_HYDROGEN_MINIMUM_PRESSURE && temperature >= METAL_HYDROGEN_MINIMUM_HEAT)
air.adjust_moles(/datum/gas/bz, -(heat_efficency * 0.05)) //0.0005-0.0025 x mols of present hydrogen as BZ consumed, something about it decomposing
if (prob(20 * increase_factor))
air.adjust_moles(/datum/gas/hydrogen, -(heat_efficency * 14)) //14-70% of present hydrogen consumed.
if (prob(25 / increase_factor))
new /obj/item/stack/sheet/mineral/metal_hydrogen(location)
SSresearch.science_tech.add_point_type(TECHWEB_POINT_TYPE_DEFAULT, min((heat_efficency * increase_factor * 0.5), METAL_HYDROGEN_RESEARCH_MAX_AMOUNT))
air.adjust_moles(/datum/gas/bz, -(heat_efficency)) //About 70% the amount of BZ requirement consumed
if (prob(25 * increase_factor))
air.adjust_moles(/datum/gas/hydrogen, -(heat_efficency * 10)) //Still consume about 70% of the hydrogen present
new /obj/item/stack/sheet/mineral/metal_hydrogen(location)
SSresearch.science_tech.add_point_type(TECHWEB_POINT_TYPE_DEFAULT, min((heat_efficency * increase_factor * 0.5), METAL_HYDROGEN_RESEARCH_MAX_AMOUNT))

if(energy_used > 0)
var/new_heat_capacity = air.heat_capacity()
Expand Down