Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Amelia0010
Copy link
Contributor

Document the changes in your pull request

This pull request removes the sheltered quirk from the codebase.

My justification for this is twofold:

1:
I do not think it adds much to the game, to have a group of people who can only speak to one another. I think that role should belong only to the mime, who is already unable to speak. This is ultimately a value judgement, and I happen to believe that this really does not add much value.
I believe it actively takes value away, in that it adds disabilities which can be not just the user's problem. For example, a head of staff having this quirk enabled messes with everyone else as well, not just this person.

2:
I think they should not know Japanese. This doesn't necessarily require the quirk to be deleted, but I'm unsure what else to replace the language which. I'd be happy with another language taking its place, but I'm not really that fond of ninjas and people with a "negative" quirk speaking the same language. Especially not when that language was meant to make it so the ninja couldn't communicate.

Wiki Documentation

https://wiki.yogstation.net/wiki/Quirks should be updated

Changelog

🆑
rscdel: Removed "Sheltered" trait
/:cl:

@Yogbot-13 Yogbot-13 added the Revert / Deletion Altoids is probably mad about this label Jul 9, 2023
@athena413
Copy link
Contributor

Isn't there a 'british' language, for #2?

@Amelia0010
Copy link
Contributor Author

There is, not particularly fond of the syllable list (and as far as I can understand it's currently a species-specific language to Humans), but that could be doable.

For the record, #2 is my main gripe, so another language is very much also welcome (to me, i'm not sure if others dislike #1 as much as I do)

@azzzertyy
Copy link
Contributor

finally someone is based enough
this was quickfire voted ages ago but they were wrong and it should never have been added in the first place

@ToasterBiome
Copy link
Contributor

Nobody actually speaks japanese because we have race languages for every playable race now (even regular human)

@Hislyna
Copy link
Contributor

Hislyna commented Jul 10, 2023

I completely disagree on both points. For starters they do not learn any new language, they just lose the ability to speak common. Second, I have had great RP moments using sheltered amd using the Me" function. It brings a new way to RP and gets around its challenges. Your reasoning for its bad for heads makes no sense when blind, deaf, and pacifist exist which you can just block heads from using instead.

@Hislyna
Copy link
Contributor

Hislyna commented Jul 10, 2023

Considering you thought they knew japanese and didnt know they understand common, when is the last time you looked at sheltered?

@neeshacark
Copy link
Contributor

for one you could just blacklist from head roles

two literally isn't true

@Amelia0010
Copy link
Contributor Author

/datum/quirk/sheltered/on_clone(data)
	var/mob/living/carbon/human/H = quirk_holder
	H.remove_language(/datum/language/common, FALSE, TRUE)
	if(!H.get_selected_language())
		H.grant_language(/datum/language/japanese)

/datum/quirk/sheltered/on_spawn()
	var/mob/living/carbon/human/H = quirk_holder
	H.remove_language(/datum/language/common, FALSE, TRUE)
	if(!H.get_selected_language())
		H.grant_language(/datum/language/japanese)

@Amelia0010
Copy link
Contributor Author

oh wait they only get Japanese if they don't have another language and nowadays everything has a second language. I mean that seems silly to me but w/e my main problem is no longer valid

@Amelia0010 Amelia0010 closed this Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Revert / Deletion Altoids is probably mad about this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants