This repository was archived by the owner on May 22, 2025. It is now read-only.
Adds update_appearance (this is friggin big news) #19643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnFulpWillard
added
Tweak
Yogbot-13
added a commit
that referenced
this pull request
Jul 19, 2023
Yogbot-13
added a commit
that referenced
this pull request
Jul 19, 2023
Yogbot-13
added a commit
that referenced
this pull request
Jul 19, 2023
Yogbot-13
added a commit
that referenced
this pull request
Jul 20, 2023
Yogbot-13
added a commit
that referenced
this pull request
Jul 20, 2023
tattax
added
TESTMERGED
Yogbot-13
added a commit
that referenced
this pull request
Jul 21, 2023
This was referenced Jul 21, 2023
Yogbot-13
added a commit
that referenced
this pull request
Jul 21, 2023
Yogbot-13
added a commit
that referenced
this pull request
Jul 21, 2023
ynot01
approved these changes
Jul 21, 2023
ToasterBiome
approved these changes
Jul 21, 2023
Contributor
|
The mask when you're toggling it on and off (the one you get in your starter box) shows twice. As if you still have it up and when you moved it to one side |
Contributor
|
the disposal bin handle sprite isnt moving anymore when you toggle it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
This is a big PR that changes nearly every single item in the game that has some form of update_icon.
This PR ports
update_appearance, which is a helper meant to allow you to update name/desc/icon/icon-state/overlays when needed with one proc, rather than manually redefining and re-adding update_icon, update_icon_state, update_name, etc.This also means it is much, much easier to port stuff from TG, with a lot of work I plan on doing being held up by the lack of this.
This may or may not break anything. Please testmerge this first.
This is a revival of #19297 - Their work has not been in vain.
Changelog
🆑
experimental: Adds update_appearance. REPORT ANYTHING WRONG YOU MAY FIND!!
bugfix: Eguns with a flashlight on them wont stick around in your action buttons unnecessarily.
/:cl: