Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@AMyriad
Copy link
Contributor

@AMyriad AMyriad commented Oct 23, 2023

Document the changes in your pull request

Adds many new translations and tweaks some existing ones to be more accurate.
(Also mfw accent string code is so shit I need to add >700 translations to make stuff consistent :D (I would fix it if I knew how))
Open to suggestions on changes if people have them.

Why is this good for the game?

Improves the accent, adds more words.

Testing

This does not need testing.

Changelog

🆑 AMyriad
tweak: Tweaked and improved the Nordic accent
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Oct 23, 2023
@AMyriad AMyriad changed the title Tweaks and improves the Nordic (also makes it the longest one in the game lol) Tweaks and improves the Nordic accent (also makes it the longest one in the game lol) Oct 23, 2023
@Necrosium
Copy link
Contributor

Bjørn

@AMyriad
Copy link
Contributor Author

AMyriad commented Oct 23, 2023

Bjørn

Good word for bear, yes, but I'm trying to keep it as understandable to ye average american/brit as possible.
Average person would probably need context when hearing this word, and would likely pronounce the "J" as a "J" instead of a "Y"-sound.
(also uhhh toes the line on rule 0.6 maybe)

@Necrosium
Copy link
Contributor

Bjørn

Good word for bear, yes, but I'm trying to keep it as understandable to ye average american/brit as possible. Average person would probably need context when hearing this word, and would likely pronounce the "J" as a "J" instead of a "Y"-sound. (also uhhh toes the line on rule 0.6 maybe)

it's a meme post don't take it seriously

@AMyriad
Copy link
Contributor Author

AMyriad commented Oct 23, 2023

Bjørn

Good word for bear, yes, but I'm trying to keep it as understandable to ye average american/brit as possible. Average person would probably need context when hearing this word, and would likely pronounce the "J" as a "J" instead of a "Y"-sound. (also uhhh toes the line on rule 0.6 maybe)

it's a meme post don't take it seriously

oh okey
image

@Moltijoe Moltijoe merged commit 7be4450 into yogstation13:master Oct 26, 2023
Yogbot-13 added a commit that referenced this pull request Oct 26, 2023
@AMyriad AMyriad deleted the accentupdate branch October 26, 2023 05:56
@Hopekz
Copy link
Contributor

Hopekz commented Apr 4, 2024

@AMyriad

Heyo original PR maker of accents here:

I looked over a lot of translations and it looks like you can hit most of these cases with syllable replacements instead. It is a system I implemented into my accents later on but haven't gotten a chance to use them.

I made the following PR as a proof of concept for how to use the system so people would have something to reference in the code but it was cringe and denied but it serves as a nice tutorial on how to do it:
#8466

basically as a example relating to this PR you can replace the following:

"\bgeneticists\b": "yeneticists",
"\bgenetics\b": "yenetics",
"\bgene\b": "yene",
"\bgenes\b": "yenes",

into a single translation that is:

"gen": "yen",

This gives you the benefit of now replacing EVERY SINGLE gen word in existence and even when you encounter gen later on in some other word (not the start). Basically the /b is a breakpoint so /b on both sides tell the code "replace it only if it is exactly this."

So if for example you are interested in ONLY replacing gen at the start of a word but don't want it to replace it in the middle of the word (If you wanted to replace "Generator with Yenerator but not "Regen" with "Reyen" you'd do:
"/bgen": "yen",

Basically /b can be thought of as like a "wildcard ender" if that makes sense.

Accents are applied in order on the list as well so if you replace the "o" with "ø" near the end of the json file I think it would also hit every O as well after the translations take place but I haven't really tested that kind of thing so it would be something to try.

Let me know if you have any questions; Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants