[PORT]: Nightvision Rework (In the name of color) from TG & full refactor of our render plane, layers, and rendering plate. Also ports their Camera + updates TGUI for it. And makes emissives work better and adds a bunch of them and refractors the bar sign to be a machine to use emissives.

[cowbot92]

FULL CREDIT GOES TO THE ORIGINAL PR JESUS CHRIST tgstation/tgstation#73094
also ports tgstation/tgstation#73106 and tgstation/tgstation#50109

Special thanks to @Chubbygummibear @Moltijoe @Saraaah

Document the changes in your pull request

This PR will completely rework the way Nightvision works, and how people generally see in the dark.

Please refer to the PR linked above for all the technical jargon- I won't be able to explain it properly.

Additionally this will add emissive starlight as a bi-product, and potentially allow us to better control our lighting system

Finally, to do all of this I had to port over TG's Plane Master, Layers, Render Plate and several other things.

Why is this good for the game?

I believe it looks a lot better, right now our night vision is kinda just... removal of darkness, which is fair but I think we can go so much further by using the colours provided to us.

Emissive starlight is cool, that's about that.

Plane master needed updating as with everything else.

#Sprites

Testing

EDIT: sechud nightvision was removed

2023-11-30.20-14-02.mp4

Changelog

🆑 Cowbot92 & ChubbyGummibear & Moltijoe

wip: Ports Nightvision from TG
tweak: Ports Nightvision from TG
experimental: This is experimental

/:cl:

[cowbot92]

editors note part 2: waiting on TG or byond to update their camera stuff

[cowbot92]

Chubby fixed the cameras how is he so good

[PibeCantina]

Had a bug last round where me (ethereal) didnt produce light anymore after coming from lavaland, idk if this makes it happen but i tought i should let you know?

Me when no light in mining

[cowbot92]

Had a bug last round where me (ethereal) didnt produce light anymore after coming from lavaland, idk if this makes it happen but i tought i should let you know? Me when no light in mining

do your other sources of light work?

[PibeCantina]

Had a bug last round where me (ethereal) didnt produce light anymore after coming from lavaland, idk if this makes it happen but i tought i should let you know? Me when no light in mining

do your other sources of light work?

Yeah, i had my pka with a seclite and it would work normally when i took it out of my bag

[cowbot92]

things to test/fix before full merge:
Auto-observe parallax breaking
replays (lol)
check for stupid ethereal light breaking

[MajManatee]

It's simple, remove ethereals glow

[cowbot92]

things to test/fix before full merge: Auto-observe parallax breaking replays (lol) check for stupid ethereal light breaking

the auto-observe issue is a tg/byond issue, so yeah.
replays will be worked on when chubby finishes #21221 (Im going to keep this one open until he's finished)
ethereal lights actually do work on his PR, so once I know it's all good ill close this and we'll merge his, which includes all my files already

[cowbot92]

chubby fixed all the problems & this is included in #21221 closing it