This repository was archived by the owner on May 22, 2025. It is now read-only.
Scrubs the second "m" from the last mentions of "Centcomm" and the capital "T" from all mentions of "NanoTrasen" #21043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
semi-related
|
Contributor
Author
good idea, I'll get that here too then |
AMyriad
changed the title
Contributor
JohnFulpWillard
left a comment
JohnFulpWillard
left a comment
There was a problem hiding this comment.
There's a unit test in check_grep.sh, lines 41 to 47, preventing the use of 'centcomm', can you expand that to include NanoTrasen?
if this works, it only dies on mapping stuff
MajManatee
added
Tweak
Contributor
Author
|
unless there's an issue I don't see, this should be done now |
Moltijoe
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
I saw that "Centcom" with one m is the standard, so I corrected the two outliers.
Also fixed another typo, very minor stuff.
UPDATE: Also corrected all mentions of "NanoTrasen" to "Nanotrasen".
Why is this good for the game?
Grammar good.
Testing
Hopefully isn't needed.
Changelog
🆑
spellcheck: Scrubbed the second "m" from the last mentions of "Centcomm"
spellcheck: All mentions of "NanoTrasen" have also been corrected to "Nanotrasen"
/:cl: