This repository was archived by the owner on May 22, 2025. It is now read-only.
Fixes a bug where the break machinery objective wouldn't complete until deleted objects went through garbage collection #21736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SapphicOverload
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a thing gets qdeleted, it takes a while for it to actually count as null for the objective
this just checks if it's in the garbage collection queue
Testing
Not really possible, just trust me
🆑
bugfix: Fixes a bug where the break machinery objective wouldn't complete until deleted objects went through garbage collection
/:cl: