Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@AMyriad
Copy link
Contributor

@AMyriad AMyriad commented Jul 31, 2024

Document the changes in your pull request

  • Fixed icemeta stairs being invisible
  • Killed our current structure/stairs sprites since they're old and nasty

Why is this good for the game?

Bug fix is good
current structure/stairs sprites are godawful and I don't want to see them mapped anywhere
also keeping them the same as turf stairs makes them more seamless, and helps height illusions

Testing

Yes
image

Spriting

Lots of these icons in the goon stairs file were inconsistent (like having differently set directions) so I changed it up a bit:

Old
image

New
image

Changelog

🆑
bugfix: Fixed multi-z stairs not rendering at all (see: icemeta)
imageadd: Multi-z stairs now look nice, like every other piece of stair in the game
imagedel: Tossed old multi-z stair sprites into the 9th circle of hell where they belong
experimental: Please report or @ me if you see any upside down stairs
/:cl:

@AMyriad AMyriad requested review from a team as code owners July 31, 2024 03:01
@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Sprites This PR has spriting changes labels Jul 31, 2024
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Jul 31, 2024
@Moltijoe
Copy link
Contributor

dark middle looks upside down to me

Copy link
Contributor

@Aquizit Aquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It's a "wall." I cannot move. The miner cannot go back up the stairs nor leave the ones they are on, and anyone outside cannot enter the stairs.

@AMyriad
Copy link
Contributor Author

AMyriad commented Aug 6, 2024

merging this with access overhaul to avoid conflicts

@AMyriad AMyriad closed this Aug 6, 2024
@AMyriad AMyriad mentioned this pull request Aug 7, 2024
16 tasks
@AMyriad AMyriad deleted the stairs-fix branch August 19, 2024 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. Sprites This PR has spriting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants