-
-
Notifications
You must be signed in to change notification settings - Fork 456
[READY] Adds Preternis! #4656
[READY] Adds Preternis! #4656
Conversation
alexkar598
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta remove icon file changes
|
very nice |
yogstation/code/modules/mob/living/carbon/human/species_types/preternis/power_suck.dm
Outdated
Show resolved
Hide resolved
yogstation/code/modules/mob/living/carbon/human/species_types/preternis/preternis.dm
Outdated
Show resolved
Hide resolved
yogstation/code/modules/mob/living/carbon/human/species_types/preternis/preternis.dm
Outdated
Show resolved
Hide resolved
|
but, night vision at roundstart? this will be an indirect nerf to slings man |
|
slings have many abilities to fuck em in the ass,but slings always lose anyways |
|
virus resistance is incompatible with the inorganic biology symptom, seeing as it won't have any special effect on preternis. which makes no sense, since inorganic bio is made to allow inorganic races like golems and androids to catch viruses. make inorg bio counteract the 80% virus resist. |
|
Due to the way I coded it(a var on species code) that means that if i do such thing,any race that wants to reduce the infect chance will get the same effect and the infect chance will be ingnored if the symptom. On top of that,preternis are super fragile,it is only fair to give them virus resistance to survive slightly longer(and maybe RNG will be a bitch anyways) |
|
SYNTHS |
|
powergame shitty race, i dont care about the "damage debuffs" when these fuckers can make a chemmix to reduce all damage to nothing if they're good enough. this will only cause problems with greytide and powergame that are too obvious for the basic player, go get it merged upstream |
|
Uhh what? There is no chem mix to protect them from damage,they cannot heal from chemical sources As for the "power game shitty race",it would be nice to know why you think that and not just DIS BAD DONT ADD |
Amelia0010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these are non-important fixes, so I'll testmerge them now
code/__DEFINES/~yogs_defines/mobs.dm
Outdated
|
|
||
| #define ELECTRICITY_TO_NUTRIMENT_FACTOR 0.12 | ||
|
|
||
| #define PRETERNIS_NV_OFF 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that this is how far you can see with NV on/off, should probably have a comment though
yogstation/code/modules/mob/living/carbon/human/species_types/preternis/power_suck.dm
Outdated
Show resolved
Hide resolved
yogstation/code/modules/mob/living/carbon/human/species_types/preternis/power_suck.dm
Outdated
Show resolved
Hide resolved
yogstation/code/modules/mob/living/carbon/human/species_types/preternis/power_suck.dm
Outdated
Show resolved
Hide resolved
| if(2) | ||
| H.overlay_fullscreen("preternis_emag", /obj/screen/fullscreen/high) | ||
| H.throw_alert("preternis_emag", /obj/screen/alert/high/preternis) | ||
| to_chat(H,"<span class='danger'>ALERT! OPTIC SENSORS FAILURE.VISION PROCESSOR COMPROMISED.</span>") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a suggestion than a complaint, but I would recommend looking into the effects for cyberman conversion for their hallucinations https://github.com/yogstation13/yogstation/tree/master/code/game/gamemodes/cybermen
yogstation/code/modules/mob/living/carbon/human/species_types/preternis/power_suck.dm
Outdated
Show resolved
Hide resolved
Amelia0010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broke alt+clicking.
| @@ -0,0 +1,186 @@ | |||
| /mob/living/carbon/AltClickOn(atom/A) | |||
| dna?.species.spec_AltClickOn(A,src) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This completely overrides all altclick events. It should not completely override all altclick events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not my fault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes the bug that lets players rotate glass and pull items without a closet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't fix bugs in a feature PR unless you created the bug in the same PR, make a seperate PR for that
Co-Authored-By: alexkar598 <25136265+alexkar598@users.noreply.github.com>
…preternis/power_suck.dm Co-Authored-By: alexkar598 <25136265+alexkar598@users.noreply.github.com>
Amelia0010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the config option as well, so anyone who downloads the repo doesn't have to manually add it.
|
Did the thing for the config |
|
you forgot the use implants in hand to implant urself :) |
|
It would be a cool feature if preternis could jump-start a depleted APC or cell, transferring the same power backwards and depleting themselves for the charging process. It would also be nice to transfer power to another preternis directly (in this case they could connect to another preternis only to give charge). |
|
Now tell me why they not considered human? |
|
dis bad dont add |
1 similar comment
|
dis bad dont add |
Upsides:
Downsides:
🆑 alexkar598
rscadd: Preternis are back! Get a list of features at : #4656
/:cl: