This repository was archived by the owner on May 22, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 457
Makes the surrendering text more noticeable #6988
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 good pr |
Contributor
|
+1 very nice rp change i love very much |
Contributor
|
Time to get hulk and spam it |
Contributor
|
People are just going to spam this. |
Contributor
|
The delay is too long to spam effectively |
alexkar598
suggested changes
Nov 2, 2019
Member
alexkar598
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line endings,fix em
get a better git client too
|
This might be nice as a button on the IC tab. |
Contributor
|
If used in the middle of combat, this'll look like a combat message, since it uses the same span. |
|
Some kind of color change then? Yellow would work for dark mode. |
Contributor
|
Please fix these line endings. |
Member
|
Been a week without sign of life from the author. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The surrender emote is currently useless. It being simple generic black text makes it very hard to notice, especially in the middle of combat, where you would want to use the emote. This PR simply makes that text huge and red so that it can be seen even when you're about to shoot some poor bloke in the face.
Changelog
🆑
tweak: added the "userdanger" class to the text that appears after using the surrender emote.
/:cl: