Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@DerelictDrone
Copy link
Contributor

@DerelictDrone DerelictDrone commented Dec 6, 2019

While the panel is open, you can:
Use your hand to turn the input/output.
Use a multitool to change between turning input or output.
Use a wrench to change stack_amt.
And of course crowbar it to deconstruct!

This might not be the best possible way of doing it, but it's the only way I know how, if there's anything that could be done better(like the descriptions) feel free to suggest.

Sprites as seen in-game
image
Full description with steps provided:
image

🆑
rscadd: You can now deconstruct and reconstruct stacking machines, as well as change their stack size, and the input or output directions separately
/:cl:

  • Construction and deconstruction with sprites
  • Setting direction and stack size
  • The ability to link Stackers to a silo.

@yogstation13-bot yogstation13-bot added Feature This adds new content to the game Icon Change labels Dec 6, 2019
@MegaEmpirical
Copy link

stack machine needs more love, thanks

@DerelictDrone
Copy link
Contributor Author

Maybe once I learn a little bit more I can make a toggle with wirecutters so it can stack /stack/ items as well as sheets, so it can stack ore, marker beacons, and cable coil.

Main issue there is that the stacky boi drops one stack no matter what.

If I come back and touch this again it'll make it so it drops stack_amt of items rather than one item with the amount variable changed to stack_amt.

So it can do more than one stack at a time, and also not eat items when it's set to a stack_amt higher than the max amount a stack can hold
(50 cable coil, one stack of 30 one stack of 20 enter a stacking machine set to stack 50. Stack machine outputs 30 cable coil and deletes the extra 20, that is the problem with dropping one item with a set amount)

@boodaliboo
Copy link
Contributor

good first pr

@DerelictDrone
Copy link
Contributor Author

DerelictDrone commented Dec 6, 2019

good first pr

#7077 was my first PR, this is my second.

@DerelictDrone
Copy link
Contributor Author

DerelictDrone commented Dec 6, 2019

Gonna re-open this when I have the two features mentioned above written, working, and tested.

Edit: Nevermind I'll save this for later I'm not good enough yet.

@DerelictDrone DerelictDrone reopened this Dec 7, 2019
@Amelia0010 Amelia0010 added the WORK IN PROGRESS This PR will take a while before its complete, but is actively being worked on. label Dec 10, 2019
@alexkar598 alexkar598 added the Stale I'm closing this in like a week if you don't push a new commit label Dec 31, 2019
@alexkar598
Copy link
Member

This Pull Request has been marked as stale due to lack of commit activity, if no further work is done within a week, this PR will be closed at which point you may contact a maintainer on discord to have this PR reopened or simply make a new one.

I wish I knew this from the beginning instead of wasting everyone's time like this.
@DerelictDrone
Copy link
Contributor Author

Sorry about the wait, I've been dragged around a lot the past week or two.
Unless anything needs to be corrected, that's the last commit I need to make.

@alexkar598 alexkar598 removed the Stale I'm closing this in like a week if you don't push a new commit label Jan 5, 2020
Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il do some more checking on the return values later but fix these in the time being

Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats not how multiline strings work

Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the last few changes

@alexkar598 alexkar598 merged commit cc30e99 into yogstation13:master Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game WORK IN PROGRESS This PR will take a while before its complete, but is actively being worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants